Load user luarc files for users that have their own lua-scripts - #707
Open
tenderlove wants to merge 1 commit into
Open
Load user luarc files for users that have their own lua-scripts#707tenderlove wants to merge 1 commit into
tenderlove wants to merge 1 commit into
Conversation
I have the lua-scripts repo cloned in $HOME/.config/darktable/lua Since darktable a4003bc (darktable-org/darktable@a4003bc) (PR darktable-org/darktable#20848) removed the direct invocation of the user luarc from lua/init.c, that responsibility moved to script_manager. But it was only called in the `if system_based` case, so my luarc was never loaded. This commit pulls the user luarc script loading up so that it runs in both modes.
Member
|
Did you test to make sure the change didn't introduce any regressions? |
Author
|
I haven't run any tests in this repo, but this fixes my setup. I'll learn how to run the tests in here :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have the lua-scripts repo cloned in $HOME/.config/darktable/lua
Since darktable a4003bc
(darktable-org/darktable@a4003bc) (PR darktable-org/darktable#20848) removed the direct invocation of the user luarc from lua/init.c, that responsibility moved to script_manager. But it was only called in the
if system_basedcase, so my luarc was never loaded.This commit pulls the user luarc script loading up so that it runs in both modes.