Skip to content

update check_version to {3,0,0} - #18

Closed
itarozzi wants to merge 1 commit into
darktable-org:masterfrom
itarozzi:master
Closed

update check_version to {3,0,0}#18
itarozzi wants to merge 1 commit into
darktable-org:masterfrom
itarozzi:master

Conversation

@itarozzi

Copy link
Copy Markdown

fix check_version() against 3.0.0 as discussed in dev mailing list

@chrik5

chrik5 commented Dec 23, 2015

Copy link
Copy Markdown
Contributor

Hi,

Will the scripts still work with older dt versions?

If not:
My copy_attach_detach_tags works since API 2.

So setting check_version to something like this
dt.configuration.check_version(...,{2,0,0},{3,0,0})
will be more appropriate?

Christian

@boucman

boucman commented Dec 27, 2015

Copy link
Copy Markdown
Member

yes, if you don't change anything you should append the newly tested api version at the end of the list of tested versions, not replace the list....

did you check the scripts entirely ? the main non-compatibility is that calls to yield now MUST have the type of yield parameter written in upper case

@boucman

boucman commented Jan 8, 2016

Copy link
Copy Markdown
Member

I will close this pull requests since we are checking scripts one by one... thx for the work anyway...

@boucman boucman closed this Jan 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants