Split Flask Dapr from Dapr#59
Merged
Merged
Conversation
youngbupark
self-requested a review
May 29, 2020 15:38
youngbupark
suggested changes
May 29, 2020
youngbupark
left a comment
youngbupark
left a comment
Contributor
There was a problem hiding this comment.
Thanks for your contribution! overall LGTM. Please look at my comments.
Contributor
Author
|
@youngbupark Made the changes. Would you also like to remove Flask from Dapr's |
Contributor
Yeah make sense. |
youngbupark
approved these changes
May 30, 2020
youngbupark
left a comment
youngbupark
left a comment
Contributor
There was a problem hiding this comment.
Thanks for your contribution!
youngbupark
added a commit
that referenced
this pull request
Jun 6, 2020
This reverts commit 69de8fc.
youngbupark
added a commit
that referenced
this pull request
Jun 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have added the following to the
flask_daprfolder.I have also added the ignoring of the
flask_daprfolder in the main Dapr package.I have also added the building of the flask_dapr package in the
build.yaml.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #53
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: