Skip to content

[Actor] Add actor state management#35

Merged
youngbupark merged 18 commits into
dapr:features/actorfrom
youngbupark:youngp/add-state
May 6, 2020
Merged

[Actor] Add actor state management#35
youngbupark merged 18 commits into
dapr:features/actorfrom
youngbupark:youngp/add-state

Conversation

@youngbupark

@youngbupark youngbupark commented Apr 27, 2020

Copy link
Copy Markdown
Contributor

Description

Add actor state management

  • Add Actor state management
  • Switch pylint to flake8
  • Move setup.py to setup.cfg configurations
  • Enable tox
  • Add state management to example

Note: flake8 will complains about the linter errors. I will fix them later.

Issue reference

#23

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@youngbupark youngbupark changed the title Add actor state management [Actor] Add actor state management Apr 27, 2020
Comment thread README.md Outdated
Comment thread dapr/actor/runtime/stateprovider.py Outdated
Comment thread README.md Outdated
Comment thread dapr/actor/client/__init__.py Outdated
Comment thread dapr/actor/runtime/context.py Outdated
Comment thread dapr/actor/runtime/stateprovider.py Outdated
"operation": MAP_CHANGE_KIND_TO_OPERATION.get(state.change_kind) or '',
"request": {
"key": state.state_name,
"value": base64encoded,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this saving data the same way as in the Java SDK?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is same as dotnet one. I assume dotnet one is compatible with java one.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not compatible.

Comment thread dapr/actor/runtime/stateprovider.py Outdated
@youngbupark

youngbupark commented Apr 29, 2020

Copy link
Copy Markdown
Contributor Author

@pruthvidhodda @artursouza @amanbha I addressed all your comments. please review this pr again.

Comment thread tests/actor/teststatemanager.py Outdated

@orizohar orizohar left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the minor requested additions in READMEs, we should start creating a docs directory in this repo and as additional functionality is added, add SDK specific documentation there.

Comment thread README.md Outdated
Comment thread README.md
Comment thread README.md Outdated
Comment thread examples/demo_actor/README.md
@orizohar

orizohar commented May 6, 2020

Copy link
Copy Markdown

@youngbupark - can you please some more context on the main REDME.md file? We need to have a sentence on dapr and links to the dapr/docs and getting started content for users who arrive here with no context.

@youngbupark

Copy link
Copy Markdown
Contributor Author

@youngbupark - can you please some more context on the main REDME.md file? We need to have a sentence on dapr and links to the dapr/docs and getting started content for users who arrive here with no context.

I will file the issue to improve README. This pr is mainly for state management implementation. This PR is going to feature branch, not master :) When we merge feature branch to master, I will update README.md

@youngbupark
youngbupark requested review from amanbha and orizohar May 6, 2020 22:00
@youngbupark
youngbupark merged commit 1411b37 into dapr:features/actor May 6, 2020
@youngbupark
youngbupark deleted the youngp/add-state branch May 6, 2020 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants