Skip to content

Add example for Kubernetes deployment#31

Merged
youngbupark merged 9 commits into
dapr:masterfrom
XavierGeerinck:master
May 13, 2020
Merged

Add example for Kubernetes deployment#31
youngbupark merged 9 commits into
dapr:masterfrom
XavierGeerinck:master

Conversation

@XavierGeerinck

Copy link
Copy Markdown
Contributor

Description

Adding example for Kubernetes deployment

Issue reference

#30 as well as #27

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@amanbha
amanbha requested a review from pruthvidhodda April 29, 2020 02:36
@youngbupark

Copy link
Copy Markdown
Contributor

@thebillkidy Sorry for the late response. Thanks for your contribution. In 0.7.0, we changed gRPC proto files a lot and added the script to generate proto stub and client codes. So the current code will not work once we release 0.7.0 release.

Here is my comments on the PR:

  1. Please wait to merge this pr until 0.7.0 dapr is released
  2. Use dapr-client instead of generating proto client codes while building docker image
  3. @pruthvidhodda already merged the proto client generation script

@XavierGeerinck

Copy link
Copy Markdown
Contributor Author

@thebillkidy Sorry for the late response. Thanks for your contribution. In 0.7.0, we changed gRPC proto files a lot and added the script to generate proto stub and client codes. So the current code will not work once we release 0.7.0 release.

Here is my comments on the PR:

  1. Please wait to merge this pr until 0.7.0 dapr is released
  2. Use dapr-client instead of generating proto client codes while building docker image
  3. @pruthvidhodda already merged the proto client generation script

Perfect, thanks a lot! Will wait until release and then update :)

@yaron2

yaron2 commented May 11, 2020

Copy link
Copy Markdown
Member

Would love to see this going forward now.

@youngbupark

Copy link
Copy Markdown
Contributor

@shalabhms Seems like we didn't publish the latest dapr-client sdk. Can you please publish it?

JFYI - I will set up CI/CD to publish it automatically in this milstone.

cc/ @amanbha

@XavierGeerinck

Copy link
Copy Markdown
Contributor Author

I blocked some time for this tomorrow, will finalize it then if the dapr-client sdk was pushed correctly :)

@amanbha

amanbha commented May 11, 2020

Copy link
Copy Markdown
Contributor

@shalabhms Seems like we didn't publish the latest dapr-client sdk. Can you please publish it?

JFYI - I will set up CI/CD to publish it automatically in this milstone.

cc/ @amanbha

I have uploaded the new python package

@youngbupark

Copy link
Copy Markdown
Contributor

@shalabhms Seems like we didn't publish the latest dapr-client sdk. Can you please publish it?
JFYI - I will set up CI/CD to publish it automatically in this milstone.
cc/ @amanbha

I have uploaded the new python package

@amanbha Thanks! :)

@XavierGeerinck

Copy link
Copy Markdown
Contributor Author

@youngbupark example updated for Dapr v0.7.1 😊

P.S. Thanks a lot for updating the other examples as well!

Comment thread examples/kubernetes/invoke-simple/Proto/dapr.proto Outdated
@@ -0,0 +1,13 @@
if [ -z $1 -o -z $2 ]; then
echo "Usage: ./generate-proto.sh <LOCATION_PROTO> <OUTPUT_FOLDER>"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: we can remove this script now because there is the script in root.

@youngbupark youngbupark left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution!

@youngbupark
youngbupark merged commit 5132914 into dapr:master May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants