Add json deserialization convenience method#293
Merged
Conversation
berndverst
reviewed
Nov 5, 2021
Codecov Report
@@ Coverage Diff @@
## master #293 +/- ##
==========================================
+ Coverage 89.38% 89.47% +0.09%
==========================================
Files 52 52
Lines 2147 2156 +9
==========================================
+ Hits 1919 1929 +10
+ Misses 228 227 -1
Continue to review full report at Codecov.
|
wmeints
changed the title
wcs1only
approved these changes
Nov 5, 2021
berndverst
pushed a commit
to berndverst/python-sdk
that referenced
this pull request
Nov 5, 2021
* Add json deserialization convience method * Fix flake8 errors * Fix typing errors * Revert change to test to fix CI * Add test for json method in bulk state item * Fix linting error
wcs1only
pushed a commit
that referenced
this pull request
Nov 5, 2021
* update proto and bump version to 1.4.0rc.1 * Add json deserialization convenience method (#293) * Add json deserialization convience method * Fix flake8 errors * Fix typing errors * Revert change to test to fix CI * Add test for json method in bulk state item * Fix linting error * don't use dev version in release branch Co-authored-by: Willem Meints <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the
json()method to responses that contain data to deserialize the content to a dictionary.This should make the convenience layer a little bit easier to work with.
Issue reference
Fixes #88
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: