Add getJsonRpcApiFromDnpName - #37
Merged
Merged
Conversation
pablomendezroyo
approved these changes
Nov 6, 2023
dappnodedev
force-pushed
the
marc/add_getJsonRpcApiFromDnpName
branch
from
November 6, 2023 15:27
5d0c576 to
7a6af53
Compare
dappnodedev
approved these changes
Nov 6, 2023
Marketen
marked this pull request as ready for review
November 6, 2023 15:43
pablomendezroyo
approved these changes
Nov 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new method
getJsonRpcApiFromDnpNameand a unit test for it. It returns the JSON RPC api of any staking client given its dnpName.This method should replace
getUrlFromDnpName:types/src/utils/stakers.ts
Line 20 in 3f999ba