Skip to content

review version tags - #5

Closed
jesusholoo wants to merge 1 commit into
dapplion/version-tagsfrom
review/version-tags
Closed

review version tags#5
jesusholoo wants to merge 1 commit into
dapplion/version-tagsfrom
review/version-tags

Conversation

@jesusholoo

Copy link
Copy Markdown
Collaborator
  • Add NewTag event
  • Add sanity check to avoid push some tag that points the versionId 0 ( which does not exist).

@jesusholoo
jesusholoo requested a review from dapplion May 19, 2022 13:59
@dapplion

Copy link
Copy Markdown
Contributor

Thanks for the contribution!

Add sanity check to avoid push some tag that points the versionId 0 ( which does not exist)

I intentionally allowed value 0 to effectively remove tags. If you want a tag to point to 0, getTag() will revert. Let me know if you see any issues with that.

@jesusholoo jesusholoo closed this May 20, 2022
dapplion added a commit that referenced this pull request May 26, 2022
dapplion added a commit that referenced this pull request May 26, 2022
dapplion added a commit that referenced this pull request May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants