Skip to content

remove stringjs dependency, add grunt-cli - #10

Merged
danhper merged 1 commit into
danhper:masterfrom
kuceb:master
Sep 22, 2018
Merged

danhper merged 1 commit into
danhper:masterfrom
kuceb:master

Conversation

@kuceb

@kuceb kuceb commented Sep 18, 2018

Copy link
Copy Markdown
Contributor

Stringjs has a high severity vulnerability, and it was trivial to remove.

@coveralls

coveralls commented Sep 18, 2018 •

Copy link
Copy Markdown

Coverage Status

Coverage increased (+1.6%) to 99.412% when pulling 6ebd71c on Bkucera:master into 35761cd on tuvistavie:master.

@danhper

danhper commented Sep 20, 2018

Copy link
Copy Markdown
Owner

Hi, thanks for the PR.
Is there any reason why you comitted the lib directory to git?
As it is built from src, I would rather keep it ignored unless there is a good reason not to do so.

@kuceb

kuceb commented Sep 21, 2018 •

Copy link
Copy Markdown
Contributor Author

@tuvistavie yea, I committed that on my fork so I could directly ref my source as the npm package version. Didn't mean for that to show up here 😄

edit: fixed

@danhper
danhper merged commit 7b0ac7f into danhper:master Sep 22, 2018
@danhper

danhper commented Sep 22, 2018

Copy link
Copy Markdown
Owner

Perfect, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants