Conversation
Add httptransport.New, which builds a transport with Go's DefaultTransport settings and its own pool, and use it wherever we cloned http.DefaultTransport through an unchecked *http.Transport assertion (LLM local tunnels, offered part content, remote cache uploads, Dang nested clients). That assertion panics if anything swaps the variable, as some core tests do. The Cloud exporters' hand-written copy of the same settings now uses it too. Signed-off-by: Alex Suraci <[email protected]>
vito
force-pushed
the
httptransport-cleanup
branch
from
October 2, 2026 01:35
6d52e82 to
fe6c019
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several places build their own HTTP transport by cloning
http.DefaultTransportthrough an unchecked type assertion:That panics if anything has replaced
http.DefaultTransportwith a differentRoundTripper.package coretests already do this (core/lazy_operation_execution_test.go).This adds
util/httptransport.New(), which returns a new transport with Go'sDefaultTransportsettings and its own connection pool. The settings come from the hand-written copy the Cloud exporters adopted in 2d57a93. It replaces:core/llm_otel.go: local LLM endpoints dialed through the session tunneldagql/cache_part_content.go: the offered part-content transportengine/remotecache/remotecache.go: the blob upload clientcore/sdk/dang/shared/shared.goand its test: Dang nested clients (fix(dang): drain the nested client's connection pool before shutdown #14180)engine/telemetry/cloud_export_sequence.go: the Cloud exporters' copy of these settingsA test checks that
New()keeps matchingDefaultTransport's settings, so it notices if Go changes them.Not changed here:
.dagger/modules/cli-dev/release_github.go(CI tooling in a separate module) and the registry resolver, which already checks its type assertion.No behavior change is intended, so there's no changelog fragment.