Skip to content

chore(core): Add makeActivityReducer test#680

Open
seonghyeonkimm wants to merge 1 commit intodaangn:mainfrom
seonghyeonkimm:chore/add-make-activity-reducer-test
Open

chore(core): Add makeActivityReducer test#680
seonghyeonkimm wants to merge 1 commit intodaangn:mainfrom
seonghyeonkimm:chore/add-make-activity-reducer-test

Conversation

@seonghyeonkimm
Copy link
Copy Markdown
Contributor

@seonghyeonkimm seonghyeonkimm commented Jan 29, 2026

  • stackflow 내부 공부해보면서 makeActivityReducer test 하나 작성해봤어요.
  • 사용안되는 import 삭제와 사용 안되는 param _로 변경하는 작업을 해봤어요.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 29, 2026

⚠️ No Changeset found

Latest commit: 54375c6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 29, 2026 •
edited
Loading

📝 Walkthrough

Summary by CodeRabbit

  • Tests

    • Added comprehensive test suite covering activity management transitions, state handling, and edge cases including step manipulation and exit behaviors.

  • Chores

    • Minor code cleanup to improve maintainability.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

Comprehensive unit test suite added for activity reducer logic covering event transitions (Replaced, Popped, StepPushed, StepReplaced, StepPopped) with deterministic timeline controls. Minor cleanup: unused parameter renamed in StepPopped handler; DomainEvent import removed.

Changes

Cohort / File(s) Summary
Activity Reducer Tests
core/src/activity-utils/makeActivityReducer.spec.ts		 New comprehensive test suite covering Replaced, Popped (with time-based and skipExitActiveState scenarios), StepPushed, StepReplaced, and StepPopped event transitions. Tests verify state transitions, parameter updates, step management, and resumedAt-based logic.
Activity Reducer Implementation
core/src/activity-utils/makeActivityReducer.ts		 Minor refactoring: StepPopped handler parameter renamed to _ to mark as unused; DomainEvent import removed from union type.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a test suite for the makeActivityReducer function, with minor refactoring (unused imports/params).
Description check ✅ Passed The description is relevant to the changeset, mentioning the test addition and cleanup of unused imports and parameters, though it uses non-English text.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Jan 29, 2026

commit: 54375c6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@seonghyeonkimm