Skip to content

Spawn real Chrome for the login window - #649

Open
chaosk wants to merge 2 commits into
mainfrom
ksocha/dru-581-spawn-real-chrome-for-the-login-window
Open

chaosk wants to merge 2 commits into
mainfrom
ksocha/dru-581-spawn-real-chrome-for-the-login-window

Conversation

@chaosk

@chaosk chaosk commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator

https://linear.app/fellaworks/issue/DRU-581/spawn-real-chrome-for-the-login-window

The login window is a raw Google Chrome spawn. Playwright only pours storage_state into the profile. The image installs Chrome on amd64 and arm64.

Made with Cursor

@chaosk
chaosk requested a review from czpython as a code owner September 19, 2026 13:41

@czpython czpython left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built the image at e0f7dfc on arm64 and ran each launch mode. I attached the way a borrow does: connectOverCDP, then contexts[0].

Two blockers:

  1. The window stops Chrome with SIGTERM. Chrome does not flush its cookie store on SIGTERM, so a login can be lost. See the comment on the finally block.
  2. Nothing passes --drive. sessions.py still runs session-launch {mode}, so each borrow gets the raw spawn. See the comment on launchDriven.

One question. The ticket names no login that fails on main. Which login fails today? navigator.webdriver is false in the raw window, and the flag from #274 gives the same result on main. The raw spawn costs the proxy relay, so I want the failing case before we take that cost.

What holds: Google's apt repo has google-chrome-stable 153.0.8010.52 for arm64, and the arm64 build installed it from apt. The start URL opens in the raw window.

Comment thread deploy/browser/session-launch
Comment thread deploy/browser/session-launch Outdated
Comment thread deploy/browser/session-launch Outdated
Comment thread deploy/browser/session-launch
Comment thread deploy/browser/session-launch Outdated
Comment thread deploy/browser/Dockerfile Outdated
Comment thread deploy/browser/Dockerfile Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants