Reject a host request that names an image and a template - #53
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A host request that named both an image and a template kept the image and silently dropped the template. Druks sent its installation image with every template, so its templated sandboxes booted the plain image without their setup (czpython/druks#646).
HostCreatenow rejects a request that names both, with422. A request that names a template always boots the template's image. The architecture doc states the rule, and the test that pinned the old precedence now checks the rejection.Merge after czpython/druks#646 is deployed. Until then, Druks sends both, and its templated hosts would fail with
422.