Repository navigation
bugfix: Resolve the correct reference type for objects - #64
Merged
Merged
Conversation
was not properly being resolved at the top level of a property.
This reverts commit 8225ca3. This was a red herring, and not the issue at all.
The classbuilder works on the schema object, and ends up changing values in it as types are discovered and resolved. This causes problems when calling build_classes more than once. This change makes it so the builder always uses a copy of the schema when calling build_classes()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The classbuilder works on the schema object, and ends up changing values
in it as types are discovered and resolved. This causes problems when
calling build_classes more than once. This change makes it so the
builder always uses a copy of the schema when calling build_classes()