Repository navigation
Fix property setting bug when typ is dict - #109
Merged
Merged
Conversation
Fixed a bug where a StopIteration exception would be raised because of improper filtering on the `validators.SCHEMA_TYPE_MAPPING` when searching for a property's type definition. Added a regression test for the bug. The test uses a schema where a property's `type` was defined in a `oneOf`. This hits the code path of the bug.
houndci-bot
reviewed
Nov 21, 2017
| @@ -0,0 +1,27 @@ | |||
| import pytest | |||
There was a problem hiding this comment.
'pytest' imported but unused
Contributor
Author
|
Woo! Thanks for the merge! :) |
Contributor
Author
|
Friendly ping @cwacek, just wondering when we can see a patch release for this. <3 |
Owner
|
My bad. Just created a tag that should automatically get transformed into a
release as soon as TravisCI gets around to it.
…On Mon, Dec 4, 2017 at 9:23 AM, Matt Broomfield ***@***.***> wrote:
Friendly ping @cwacek <https://github.com/cwacek>, just wondering when we
can see a patch release for this. <3
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#109 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAh-kpurXnu_smcYlytLe5CmnZ03Sx4aks5s9ABogaJpZM4QmXBy>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug where a StopIteration exception would be raised because of
improper filtering on the
validators.SCHEMA_TYPE_MAPPINGwhensearching for a property's type definition.
Added a regression test for the bug. The test uses a schema where a property's
typewas defined in aoneOf.This hits the code path of the bug.