Support appending pre-encoded data when serializing#510
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #510 +/- ##
==========================================
- Coverage 94.71% 94.49% -0.23%
==========================================
Files 9 9
Lines 851 853 +2
Branches 130 131 +1
==========================================
Hits 806 806
- Misses 19 20 +1
- Partials 26 27 +1 ☔ View full report in Codecov by Sentry. |
ctalkington
added
the
enhancement
ctalkington
changed the title
ctalkington
changed the title
ctalkington
requested changes
May 18, 2024
ctalkington
approved these changes
May 18, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @ctalkington, seems I figured out how to print a document using this library. I found a missing part comparing your source with sealsystems/node-ipp.
In sealsystems lib, they used a 'custom'
dataattribute in which they set the file data (see this example) and then they add the 'already-byte' data directly to the encoded message.so in your `serializer.py', it is needed a
just before returning
encoded.In my test, a pdf file is correctly printed.
Let me know if you intend to update this library or if I need to use my fork (i need to use this library without patching the source)