Skip to content

Fix for change in Kernel 4.4.168#53

Merged
cristian-stoica merged 1 commit into
cryptodev-linux:masterfrom
kingforaday:master
Jul 28, 2020
Merged

Fix for change in Kernel 4.4.168#53
cristian-stoica merged 1 commit into
cryptodev-linux:masterfrom
kingforaday:master

Conversation

@kingforaday

@kingforaday kingforaday commented Jul 19, 2020

Copy link
Copy Markdown

Fixes #46 -- Kernel 4.4.168 removed the force flag from get_user_pages:

@@ -1195,19 +1199,17 @@ long __get_user_pages(struct task_struct *tsk, struct mm_struct *mm,
 		      struct vm_area_struct **vmas, int *nonblocking);
 long get_user_pages(struct task_struct *tsk, struct mm_struct *mm,
 		    unsigned long start, unsigned long nr_pages,
-		    int write, int force, struct page **pages,
+		    unsigned int gup_flags, struct page **pages,
 		    struct vm_area_struct **vmas);

@cristian-stoica

cristian-stoica commented Jul 20, 2020

Copy link
Copy Markdown
Collaborator

Keeping up with kernel stable shows up some challenges.
Is the 4.4.168 change a backport from something more recent? Should we do something about them?

@kingforaday

kingforaday commented Jul 20, 2020 •
edited
Loading

Copy link
Copy Markdown
Author

4.4 is longterm until Feb 2022 and the change in .168 holds true until the current 4.4.230 release on 2020-07-09

@cristian-stoica
cristian-stoica merged commit 2b264f9 into cryptodev-linux:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

make error

2 participants

@kingforaday @cristian-stoica