Skip to content

add storageId params - #9

Merged
andrii-bodnar merged 1 commit into
crowdin:mainfrom
punkyoon:feature/fix-add-file-api
Apr 22, 2021
Merged

add storageId params#9
andrii-bodnar merged 1 commit into
crowdin:mainfrom
punkyoon:feature/fix-add-file-api

Conversation

@punkyoon

@punkyoon punkyoon commented Apr 22, 2021

Copy link
Copy Markdown
Contributor

resolve #8

@andrii-bodnar

andrii-bodnar commented Apr 22, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

HI @punkyoon, thanks a lot for your contribution!

Looks great. Please fix the Unit tests and then I'll merge this PR.

_______ TestSourceFilesResource.test_add_file[in_params0-request_data0] ________
crowdin_api/api_resources/source_files/tests/test_source_files_resources.py:400: in test_add_file
    assert resource.add_file(projectId=1, **in_params) == "response"
E   TypeError: add_file() missing 1 required positional argument: 'storageId'

@andrii-bodnar
andrii-bodnar merged commit a53b49a into crowdin:main Apr 22, 2021
@punkyoon
punkyoon deleted the feature/fix-add-file-api branch April 22, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrii-bodnar andrii-bodnar andrii-bodnar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

wrong add file api params

2 participants

@punkyoon @andrii-bodnar