Skip to content

fix file uploading - #7

Closed
punkyoon wants to merge 1 commit into
crowdin:mainfrom
punkyoon:feature/fix-file-uploading
Closed

punkyoon wants to merge 1 commit into
crowdin:mainfrom
punkyoon:feature/fix-file-uploading

Conversation

@punkyoon

Copy link
Copy Markdown
Contributor

resolve #6

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #7 (aa8d165) into main (17417ab) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   99.26%   99.26%   +0.01%     
==========================================
  Files          60       60              
  Lines        1609     1611       +2     
  Branches       60       60              
==========================================
+ Hits         1597     1599       +2     
  Misses          8        8              
  Partials        4        4              
Impacted Files Coverage Δ
crowdin_api/requester.py 97.50% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17417ab...aa8d165. Read the comment docs.

@andrii-bodnar

Copy link
Copy Markdown
Member

Hi @punkyoon!

Thanks a lot for your suggestion and congrats on your first contribution to the Crowdin Python client 🎉

For me, it looks good, but I suggest also @yuziaka review this PR.

@andrii-bodnar
andrii-bodnar requested a review from yuziaka April 22, 2021 08:48
@andrii-bodnar

Copy link
Copy Markdown
Member

@punkyoon,

@yuziaka a bit extended your solution in #11 which has been merged.

This PR will be closed, but do not worry, it was very helpful 🙂

@punkyoon
punkyoon deleted the feature/fix-file-uploading branch April 22, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix file uploading

3 participants