tests for notifcations

hjwp · hjwp · commit a2b76404a55e · 2020-01-03T23:35:41.000Z
diff --git a/tests/unit/__init__.py b/tests/unit/__init__.py
diff --git a/tests/unit/fakes.py b/tests/unit/fakes.py
@@ -0,0 +1,58 @@
+from typing import Dict, List
+from collections import defaultdict
+from unittest import mock
+from allocation.adapters import notifications, repository
+from allocation.service_layer import messagebus, unit_of_work
+
+
+class FakeRepository(repository.AbstractRepository):
+
+    def __init__(self, products):
+        super().__init__()
+        self._products = set(products)
+
+    def _add(self, product):
+        self._products.add(product)
+
+    def _get(self, sku):
+        return next((p for p in self._products if p.sku == sku), None)
+
+    def _get_by_batchref(self, batchref):
+        return next((
+            p for p in self._products for b in p.batches
+            if b.reference == batchref
+        ), None)
+
+
+class FakeUnitOfWork(unit_of_work.AbstractUnitOfWork):
+
+    def __init__(self):
+        self.products = FakeRepository([])
+        self.committed = False
+
+    def _commit(self):
+        self.committed = True
+
+    def rollback(self):
+        pass
+
+
+
+class FakeBus(messagebus.MessageBus):
+    def __init__(self):
+        uow = FakeUnitOfWork()
+        super().__init__(
+            uow=uow,
+            notifications=FakeNotifications(),
+            publish=mock.Mock(),
+        )
+        uow.bus = self
+
+
+class FakeNotifications(notifications.AbstractNotifications):
+
+    def __init__(self):
+        self.sent = defaultdict(list)  # type: Dict[str, List[str]]
+
+    def send(self, destination, message):
+        self.sent[destination].append(message)
diff --git a/tests/unit/test_handlers.py b/tests/unit/test_handlers.py
@@ -1,55 +1,9 @@
 from __future__ import annotations
 from datetime import date
-from unittest import mock
 import pytest
-from allocation.adapters import repository
 from allocation.domain import commands
-from allocation.service_layer import handlers, messagebus, unit_of_work
-
-
-class FakeRepository(repository.AbstractRepository):
-
-    def __init__(self, products):
-        super().__init__()
-        self._products = set(products)
-
-    def _add(self, product):
-        self._products.add(product)
-
-    def _get(self, sku):
-        return next((p for p in self._products if p.sku == sku), None)
-
-    def _get_by_batchref(self, batchref):
-        return next((
-            p for p in self._products for b in p.batches
-            if b.reference == batchref
-        ), None)
-
-
-class FakeUnitOfWork(unit_of_work.AbstractUnitOfWork):
-
-    def __init__(self):
-        self.products = FakeRepository([])
-        self.committed = False
-
-    def _commit(self):
-        self.committed = True
-
-    def rollback(self):
-        pass
-
-
-
-class FakeBus(messagebus.MessageBus):
-    def __init__(self):
-        uow = FakeUnitOfWork()
-        super().__init__(
-            uow=uow,
-            send_mail=mock.Mock(),
-            publish=mock.Mock(),
-        )
-        uow.bus = self
-
+from allocation.service_layer import handlers
+from .fakes import FakeBus
 
 
 class TestAddBatch:
@@ -99,10 +53,9 @@ def test_sends_email_on_out_of_stock_error():
         bus = FakeBus()
         bus.handle(commands.CreateBatch("b1", "POPULAR-CURTAINS", 9, None))
         bus.handle(commands.Allocate("o1", "POPULAR-CURTAINS", 10))
-        assert bus.dependencies["send_mail"].call_args == mock.call(
-            "stock@made.com",
+        assert bus.dependencies['notifications'].sent['stock@made.com'] == [
             f"Out of stock for POPULAR-CURTAINS",
-        )
+        ]
 
 
 class TestChangeBatchQuantity:
