go DI, still use mocks

hjwp · hjwp · commit 636f7347f251 · 2020-02-23T11:51:46.000Z
diff --git a/test_sync.py b/test_sync.py
@@ -1,10 +1,26 @@
+from datetime import date
 from unittest import mock
 
 from use_cases import create_shipment, API_URL
 from domain import Shipment, OrderLine
 from cargo_api import RealCargoAPI
 
+class FakeCargoAPI:
+
+    def __init__(self):
+        self._shipments = {}
+
+    def get_latest_eta(self, reference) -> date:
+        return self._shipments[reference].eta
+
+    def sync(self, shipment: Shipment):
+        self._shipments[shipment.reference] = shipment
+
+    def __contains__(self, shipment):
+        return shipment in self._shipments.values()
+
+
 def test_create_shipment_syncs_to_api():
-    with mock.patch('use_cases.cargo_api') as mock_cargo_api:
-        shipment = create_shipment({'sku1': 10}, incoterm='EXW')
-        assert mock_cargo_api.sync.call_args == mock.call(shipment)
+    mock_api = mock.Mock()
+    shipment = create_shipment({'sku1': 10}, incoterm='EXW', cargo_api=mock_api)
+    assert mock_api.sync.call_args == mock.call(shipment)
diff --git a/use_cases.py b/use_cases.py
@@ -8,13 +8,12 @@
 
 from domain import Shipment, OrderLine
 from notifications import notify_delay, notify_new_large_shipment
-from cargo_api import RealCargoAPI
-cargo_api = RealCargoAPI()
+from cargo_api import CargoAPI, RealCargoAPI
 
 API_URL = 'https://example.org'
 
 
-def create_shipment(quantities: Dict[str, int], incoterm) -> Shipment:
+def create_shipment(quantities: Dict[str, int], incoterm: str, cargo_api: CargoAPI) -> Shipment:
     print(uuid)
     reference = uuid.uuid4().hex[:10]
     order_lines = [OrderLine(sku=sku, qty=qty) for sku, qty in quantities.items()]
