little refactor

hjwp · hjwp · commit 623c9d037809 · 2019-02-08T11:24:11.000Z
diff --git a/domain_model.py b/domain_model.py
@@ -95,11 +95,10 @@ def for_(order: Order, source: Stock):
             order=order
         )
 
-    def supplement_with(self, allocation):
-        for line in allocation.lines:
-            if line.sku in self.skus:
-                continue
-            self.lines.append(line)
+    def supplement_with(self, other_allocation):
+        self.lines.extend(
+            l for l in other_allocation.lines if l.sku not in self.skus
+        )
 
     @property
     def is_complete(self):
