new test that we can also load existing allocations

hjwp · hjwp · commit 20a081858bc0 · 2021-02-24T21:32:39.000Z
diff --git a/src/bin/allocate-from-csv b/src/bin/allocate-from-csv
@@ -1,46 +1,82 @@
 #!/usr/bin/env python
+from __future__ import annotations
+from typing import Dict
 import csv
 import sys
 from datetime import datetime
 from pathlib import Path
 
 from allocation.domain import model
+from allocation.service_layer import services, unit_of_work
+from allocation.adapters import repository
 
 
-def load_batches(batches_path):
-    batches = []
-    with batches_path.open() as inf:
-        reader = csv.DictReader(inf)
-        for row in reader:
-            if row["eta"]:
-                eta = datetime.strptime(row["eta"], "%Y-%m-%d").date()
-            else:
-                eta = None
-            batches.append(
-                model.Batch(
-                    ref=row["ref"], sku=row["sku"], qty=int(row["qty"]), eta=eta
-                )
-            )
-    return batches
+class CsvRepository(repository.AbstractRepository):
+    def __init__(self, folder):
+        self._batches_path = Path(folder) / "batches.csv"
+        self._allocations_path = Path(folder) / "allocations.csv"
+        self._batches = {}  # type: Dict[str, model.Batch]
+        self._load()
 
+    def get(self, reference):
+        return self._batches.get(reference)
+
+    def add(self, batch):
+        self._batches[batch.reference] = batch
+
+    def _load(self):
+        with self._batches_path.open() as f:
+            reader = csv.DictReader(f)
+            for row in reader:
+                ref, sku = row["ref"], row["sku"]
+                qty = int(row["qty"])
+                if row["eta"]:
+                    eta = datetime.strptime(row["eta"], "%Y-%m-%d").date()
+                else:
+                    eta = None
+                self._batches[ref] = model.Batch(ref=ref, sku=sku, qty=qty, eta=eta)
+        if self._allocations_path.exists() is False:
+            return
+        with self._allocations_path.open() as f:
+            reader = csv.DictReader(f)
+            for row in reader:
+                batchref, orderid, sku = row["batchref"], row["orderid"], row["sku"]
+                qty = int(row["qty"])
+                line = model.OrderLine(orderid, sku, qty)
+                batch = self._batches[batchref]
+                batch._allocations.add(line)
+
+    def list(self):
+        return list(self._batches.values())
 
-def main(folder):
-    batches_path = Path(folder) / "batches.csv"
-    orders_path = Path(folder) / "orders.csv"
-    allocations_path = Path(folder) / "allocations.csv"
 
-    batches = load_batches(batches_path)
+class CsvUnitOfWork(unit_of_work.AbstractUnitOfWork):
+    def __init__(self, folder):
+        self.batches = CsvRepository(folder)
 
-    with orders_path.open() as inf, allocations_path.open("w") as outf:
-        reader = csv.DictReader(inf)
-        writer = csv.writer(outf)
-        writer.writerow(["orderid", "sku", "batchref"])
+    def commit(self):
+        with self.batches._allocations_path.open("w") as f:
+            writer = csv.writer(f)
+            writer.writerow(["orderid", "sku", "qty", "batchref"])
+            for batch in self.batches.list():
+                for line in batch._allocations:
+                    writer.writerow(
+                        [line.orderid, line.sku, line.qty, batch.reference]
+                    )
+
+    def rollback(self):
+        pass
+
+
+def main(folder):
+    orders_path = Path(folder) / "orders.csv"
+    uow = CsvUnitOfWork(folder)
+    with orders_path.open() as f:
+        reader = csv.DictReader(f)
         for row in reader:
             orderid, sku = row["orderid"], row["sku"]
             qty = int(row["qty"])
-            line = model.OrderLine(orderid, sku, qty)
-            batchref = model.allocate(line, batches)
-            writer.writerow([line.orderid, line.sku, batchref])
+            services.allocate(orderid, sku, qty, uow)
 
 
 if __name__ == "__main__":
diff --git a/tests/e2e/test_csv.py b/tests/e2e/test_csv.py
@@ -1,12 +1,23 @@
 import csv
-import subprocess
 import uuid
+from importlib.util import spec_from_loader, module_from_spec
+from importlib.machinery import SourceFileLoader
+from pathlib import Path
 
 
 def random_ref(prefix):
     return prefix + "-" + uuid.uuid4().hex[:10]
 
 
+def run_cli_script(folder):
+    """a bit of python import hackery to load the script and run its main()"""
+    path = Path(__file__).parent / "../../src/bin/allocate-from-csv"
+    spec = spec_from_loader("script", SourceFileLoader("script", str(path)))
+    script = module_from_spec(spec)
+    spec.loader.exec_module(script)
+    script.main(folder)
+
+
 def test_cli_app_reads_csvs_with_batches_and_orders_and_outputs_allocations(make_csv):
     sku1, sku2 = random_ref("s1"), random_ref("s2")
     batch1, batch2, batch3 = random_ref("b1"), random_ref("b2"), random_ref("b3")
@@ -23,7 +34,7 @@ def test_cli_app_reads_csvs_with_batches_and_orders_and_outputs_allocations(make
         [order_ref, sku2, 12],
     ])
 
-    subprocess.run(["allocate-from-csv", orders_csv.parent])
+    run_cli_script(orders_csv.parent)
 
     expected_output_csv = orders_csv.parent / "allocations.csv"
     with open(expected_output_csv) as f:
@@ -33,3 +44,33 @@ def test_cli_app_reads_csvs_with_batches_and_orders_and_outputs_allocations(make
         [order_ref, sku1, "3", batch1],
         [order_ref, sku2, "12", batch2],
     ]
+
+
+def test_cli_app_also_reads_existing_allocations_and_can_append_to_them(make_csv):
+    sku = random_ref("s")
+    batch1, batch2 = random_ref("b1"), random_ref("b2")
+    old_order, new_order = random_ref("o1"), random_ref("o2")
+    make_csv("batches.csv", [
+        ["ref", "sku", "qty", "eta"],
+        [batch1, sku, 10, "2011-01-01"],
+        [batch2, sku, 10, "2011-01-02"],
+    ])
+    make_csv("allocations.csv", [
+        ["orderid", "sku", "qty", "batchref"],
+        [old_order, sku, 10, batch1],
+    ])
+    orders_csv = make_csv("orders.csv", [
+        ["orderid", "sku", "qty"],
+        [new_order, sku, 7],
+    ])
+
+    run_cli_script(orders_csv.parent)
+
+    expected_output_csv = orders_csv.parent / "allocations.csv"
+    with open(expected_output_csv) as f:
+        rows = list(csv.reader(f))
+    assert rows == [
+        ["orderid", "sku", "qty", "batchref"],
+        [old_order, sku, "10", batch1],
+        [new_order, sku, "7", batch2],
+    ]
