Skip to content

cppcheck.wxs: Use underscore instead of dash#2915

Merged
danmar merged 1 commit into
cppcheck-opensource:mainfrom
c72578:2020-11-21_cppcheck.wxs_Use_underscore_instead_of_dash
Nov 21, 2020
Merged

cppcheck.wxs: Use underscore instead of dash#2915
danmar merged 1 commit into
cppcheck-opensource:mainfrom
c72578:2020-11-21_cppcheck.wxs_Use_underscore_instead_of_dash

Conversation

@c72578
Copy link
Copy Markdown
Contributor

@c72578 c72578 commented Nov 21, 2020

Fixes the following errors during the Build Installer step of
release-windows GitHub Action:

cppcheck.wxs(135): error CNDL0014: The File/@Id attribute's value,
'elbrus-e1cp.xml', is not a legal identifier. Identifiers may contain
ASCII characters A-Z, a-z, digits, underscores (_), or periods (.).

cppcheck.wxs(137): error CNDL0014: The File/@Id attribute's value,
'pic8-enhanced.xml', is not a legal identifier.

Successful GitHub Action test run of release-windows:
https://github.com/c72578/cppcheck/actions/runs/375485795

Fixes the following errors during the Build Installer step of
release-windows GitHub Action:

cppcheck.wxs(135): error CNDL0014: The File/@id attribute's value,
'elbrus-e1cp.xml', is not a legal identifier. Identifiers may contain
ASCII characters A-Z, a-z, digits, underscores (_), or periods (.).

cppcheck.wxs(137): error CNDL0014: The File/@id attribute's value,
'pic8-enhanced.xml', is not a legal identifier.
@c72578 c72578 marked this pull request as ready for review November 21, 2020 01:48
@danmar danmar merged commit f5eba39 into cppcheck-opensource:main Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants