Skip to content

updated TinyXML2 to 8.0.0#2594

Closed
firewave wants to merge 1 commit into
cppcheck-opensource:masterfrom
firewave:tinyxml
Closed

updated TinyXML2 to 8.0.0#2594
firewave wants to merge 1 commit into
cppcheck-opensource:masterfrom
firewave:tinyxml

Conversation

@firewave
Copy link
Copy Markdown
Collaborator

@firewave firewave commented Apr 5, 2020

I will also prepare upstream pull requests to get rid of the compiler warnings we are seeing with that code.

@firewave
Copy link
Copy Markdown
Collaborator Author

firewave commented Apr 5, 2020

The failures are a regression in TinyXML2 which was already reported and has an open PR - see leethomason/tinyxml2#811. It was actually detected through someone running the testrunner.

@danmar
Copy link
Copy Markdown
Collaborator

danmar commented Apr 6, 2020

ok hope that will be merged.. then we can use the fixed version.

@scottfurry
Copy link
Copy Markdown
Contributor

Reported here - https://trac.cppcheck.net/ticket/9690

@danmar
Copy link
Copy Markdown
Collaborator

danmar commented May 29, 2020

I close this PR. TinyXML2 version 8.0.0 is not working for us.
Maybe version 7.1.0 works? Or we have to wait for next release..

@danmar danmar closed this May 29, 2020
@firewave
Copy link
Copy Markdown
Collaborator Author

firewave commented Jun 17, 2020

It would be great if you could give some heads-up in the future before you close stale PRs. I am have been quite busy recently and keep getting side tracked with lots of things in Cppcheck so I keep not getting around to some of these older changes.

Also if I have to re-submit them all the old discussions related to the "bad" changes are no longer attached to them which is not helpful IMO.

I do get though that you don't want stale PRs hanging around. I am not a friend of that either but sometimes that's just how it is... 😐

@danmar
Copy link
Copy Markdown
Collaborator

danmar commented Jun 18, 2020

Yes. Well .. feel free to reopen this PR with updated TinyXML2 when they release that. Or if you prefer open a new PR.

@firewave
Copy link
Copy Markdown
Collaborator Author

Ah - didn't see that since the button was disabled - will do. But I don't have permissions to re-open PRs...

@danmar
Copy link
Copy Markdown
Collaborator

danmar commented Jun 18, 2020

Ah - didn't see that since the button was disabled - will do. But I don't have permissions to re-open PRs...

oh my mistake then I thought you could reopen. Feel free to notify me and I will reopen it. If you think that there will be a new release soonish I can reopen it now. My worry was that it would take a year or so..

@c72578
Copy link
Copy Markdown
Contributor

c72578 commented Jun 22, 2020

Remark: In the meantime, leethomason/tinyxml2#811 has been accepted and merged:
leethomason/tinyxml2@6a51439

@firewave
Copy link
Copy Markdown
Collaborator Author

firewave commented Jun 22, 2020

@danmar Could you please re-open this? I will update it to the latest TinyXML2 version - or the latest stable one. Depending on how it goes.

Also need to submit some PRs for upstream warning fixes.

@danmar
Copy link
Copy Markdown
Collaborator

danmar commented Jun 22, 2020

sorry.. even I can not reopen. I guess you need to open a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants