updated TinyXML2 to 8.0.0#2594
Conversation
|
The failures are a regression in TinyXML2 which was already reported and has an open PR - see leethomason/tinyxml2#811. It was actually detected through someone running the |
|
ok hope that will be merged.. then we can use the fixed version. |
|
Reported here - https://trac.cppcheck.net/ticket/9690 |
|
I close this PR. TinyXML2 version 8.0.0 is not working for us. |
|
It would be great if you could give some heads-up in the future before you close stale PRs. I am have been quite busy recently and keep getting side tracked with lots of things in Cppcheck so I keep not getting around to some of these older changes. Also if I have to re-submit them all the old discussions related to the "bad" changes are no longer attached to them which is not helpful IMO. I do get though that you don't want stale PRs hanging around. I am not a friend of that either but sometimes that's just how it is... 😐 |
|
Yes. Well .. feel free to reopen this PR with updated TinyXML2 when they release that. Or if you prefer open a new PR. |
|
Ah - didn't see that since the button was disabled - will do. But I don't have permissions to re-open PRs... |
oh my mistake then I thought you could reopen. Feel free to notify me and I will reopen it. If you think that there will be a new release soonish I can reopen it now. My worry was that it would take a year or so.. |
|
Remark: In the meantime, leethomason/tinyxml2#811 has been accepted and merged: |
|
@danmar Could you please re-open this? I will update it to the latest TinyXML2 version - or the latest stable one. Depending on how it goes. Also need to submit some PRs for upstream warning fixes. |
|
sorry.. even I can not reopen. I guess you need to open a new PR. |
I will also prepare upstream pull requests to get rid of the compiler warnings we are seeing with that code.