Fix extern c typedef syntax error#2438
Merged
amai2012 merged 3 commits intoDec 12, 2019
Merged
Conversation
Collaborator
|
amai2012
approved these changes
Dec 10, 2019
danmar
reviewed
Dec 11, 2019
| " auto fn = []() -> foo* { return new foo(); };\n" | ||
| "}\n"); | ||
|
|
||
| checkCode( |
Collaborator
There was a problem hiding this comment.
Please move this test. This code is not garbage. It should be added in TestTokenizer::findGarbageCode().
Collaborator
|
Hello! Thanks for your contribution. What name would you like that we add in our |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
extern "C" typedef void function();
Resulted in syntax error.
This will fix the garbageCollection and adds a test for it