Update Flux Operator to 0.18.0 - #703
Conversation
Signed-off-by: Kingdon B <[email protected]>
WalkthroughThis pull request bumps the version numbers in the Flux Operator and Flux Instance charts from 0.17.0 to 0.18.0. It also adds new configuration options for the Flux Operator by introducing a reporting interval and a node selector. The changes span updates to chart metadata, documentation, deployment templates, schema definitions, and default values. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
packages/system/fluxcd-operator/charts/flux-operator/README.md (1)
51-51: Wording suggestion for priorityClassName description.
A determiner is missing in the description forpriorityClassName. Consider revising it to “The pod priority class name. Recommended value is system-cluster-critical” for improved clarity.🧰 Tools
🪛 LanguageTool
[uncategorized] ~51-~51: A determiner appears to be missing. Consider inserting it.
Context: ...tring |""| Pod priority class name. Recommended value is system-cluster-critical. | | r...(AI_EN_LECTOR_MISSING_DETERMINER)
packages/system/fluxcd-operator/charts/flux-operator/templates/deployment.yaml (1)
113-117: Addition of Node Selector Block & YAML Formatting
The new node selector block allows users to specify pod scheduling criteria via Helm values. Verify that the intended indentations are preserved when rendered. Also, note that YAML lint reports an extra blank line at line 117—please consider removing unnecessary blank lines for consistency.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 117-117: too many blank lines
(1 > 0) (empty-lines)
packages/system/fluxcd-operator/charts/flux-operator/values.schema.json (1)
197-202: Schema Definition for nodeSelector
The newnodeSelectorproperty is added as an object. The use of"type": [ "object" ](an array with a single type) is unconventional; unless intentional for future extensibility, consider specifying it as"type": "object"for clarity.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
packages/system/fluxcd-operator/charts/flux-operator/Chart.yaml(2 hunks)packages/system/fluxcd-operator/charts/flux-operator/README.md(2 hunks)packages/system/fluxcd-operator/charts/flux-operator/templates/deployment.yaml(2 hunks)packages/system/fluxcd-operator/charts/flux-operator/values.schema.json(2 hunks)packages/system/fluxcd-operator/charts/flux-operator/values.yaml(2 hunks)packages/system/fluxcd/charts/flux-instance/Chart.yaml(2 hunks)packages/system/fluxcd/charts/flux-instance/README.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
packages/system/fluxcd-operator/charts/flux-operator/README.md
[uncategorized] ~51-~51: A determiner appears to be missing. Consider inserting it.
Context: ...tring | "" | Pod priority class name. Recommended value is system-cluster-critical. | | r...
(AI_EN_LECTOR_MISSING_DETERMINER)
🪛 YAMLlint (1.35.1)
packages/system/fluxcd-operator/charts/flux-operator/templates/deployment.yaml
[warning] 117-117: too many blank lines
(1 > 0) (empty-lines)
🔇 Additional comments (12)
packages/system/fluxcd-operator/charts/flux-operator/Chart.yaml (2)
11-11: Update appVersion to v0.18.0.
The appVersion field has been updated from v0.17.0 to v0.18.0 in accordance with the new release.
28-28: Update chart version to 0.18.0.
The chart’s version field is now set to 0.18.0, ensuring consistency with the updated appVersion.packages/system/fluxcd/charts/flux-instance/Chart.yaml (2)
11-11: Update appVersion to v0.18.0.
The appVersion field is updated to v0.18.0, matching the new release and ensuring consistency across charts.
28-28: Update chart version to 0.18.0.
The chart version has been incremented to 0.18.0 to align with the updated application version.packages/system/fluxcd/charts/flux-instance/README.md (2)
3-3: Version badges updated to 0.18.0.
The version and appVersion badges now correctly reflect 0.18.0, in line with the Chart.yaml updates.
49-55: New configuration options for nodeSelector and reporting added.
The table now includes entries fornodeSelector(defaulting to an empty object) andreporting(with an interval of "5m"). These additions enhance the configurability of the deployment as described in the release notes.packages/system/fluxcd-operator/charts/flux-operator/values.yaml (2)
11-14: New reporting configuration added.
The inclusion of thereportingsection with anintervalset to 5m provides enhanced reporting capabilities for the operator. The required schema annotation ensures users supply this setting correctly.
103-105: New nodeSelector configuration added.
Adding thenodeSelectorsection (initialized as an empty object) offers flexibility for pod scheduling and is aligned with the new configuration options introduced in version 0.18.0.packages/system/fluxcd-operator/charts/flux-operator/README.md (2)
3-3: Version badges updated to 0.18.0.
The badges at the top of the README now reflect the updated version and appVersion, ensuring that documentation is consistent with the Chart.yaml and values.yaml changes.
49-55: Document new configuration options for nodeSelector and reporting.
The updated Values table now includes entries fornodeSelectorandreporting, which corresponds well with the new configurations added in the values file. This documentation helps users understand the additional customization options for pod scheduling and reporting intervals.🧰 Tools
🪛 LanguageTool
[uncategorized] ~51-~51: A determiner appears to be missing. Consider inserting it.
Context: ...tring |""| Pod priority class name. Recommended value is system-cluster-critical. | | r...(AI_EN_LECTOR_MISSING_DETERMINER)
packages/system/fluxcd-operator/charts/flux-operator/templates/deployment.yaml (1)
64-65: New Environment Variable: REPORTING_INTERVAL Configuration
These lines add theREPORTING_INTERVALenvironment variable by pulling its value from{{ .Values.reporting.interval }}. Please ensure that a default is provided in the corresponding values file and that the documentation is updated accordingly.packages/system/fluxcd-operator/charts/flux-operator/values.schema.json (1)
255-265: Schema Addition for Reporting Configuration
The newreportingproperty requires anintervalstring. Confirm that the default value (e.g.,"5m") invalues.yamlcorresponds with this schema and that the behavior is well documented.
Andrei Kvapil (kvaps)
left a comment
Andrei Kvapil (kvaps)
left a comment
There was a problem hiding this comment.
LGTM, thank you!
2 participants
Released early this week
https://github.com/controlplaneio-fluxcd/flux-operator/releases/tag/v0.18.0
Summary by CodeRabbit
New Features
Documentation