Add e2e tests - #165
Merged
Merged
Add e2e tests#165
Conversation
Andrei Kvapil (kvaps)
requested review from
George Gaál (gecube),
Nikita (nbykov0) and
Marian Koreniuk (themoriarti)
June 12, 2024 17:20
Andrei Kvapil (kvaps)
force-pushed
the
e2e
branch
3 times, most recently
from
June 12, 2024 17:40
5c1aff7 to
a3729ae
Compare
Signed-off-by: Andrei Kvapil <[email protected]>
Andrei Kvapil (kvaps)
force-pushed
the
e2e
branch
from
June 12, 2024 17:47
a3729ae to
eedc4eb
Compare
Marian Koreniuk (themoriarti)
left a comment
Marian Koreniuk (themoriarti)
left a comment
Collaborator
There was a problem hiding this comment.
After add MASQUERADE, it would be good to stop the virtual machines at the end of the test or add the possibility of configuration parameter for that.
| ip link set cozy-srv$i up | ||
| ip link set cozy-srv$i master cozy-br0 | ||
| done | ||
|
|
Collaborator
There was a problem hiding this comment.
To be able to go outside add:
echo 1 > /proc/sys/net/ipv4/ip_forward
iptables -t nat -A POSTROUTING -s 192.168.123.0/24 -j MASQUERADE
Member
Author
There was a problem hiding this comment.
I have to add check to test for this
Member
Author
There was a problem hiding this comment.
Thanks, just added this to tests
Signed-off-by: Andrei Kvapil <[email protected]>
Andrei Kvapil (kvaps)
force-pushed
the
e2e
branch
from
June 17, 2024 16:17
420add5 to
3a0bad0
Compare
Marian Koreniuk (themoriarti)
approved these changes
Jun 17, 2024
Marian Koreniuk (themoriarti)
left a comment
Marian Koreniuk (themoriarti)
left a comment
Collaborator
There was a problem hiding this comment.
Now looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add script that creates three VMs and installs Cozystack into them