[kubernetes] remove useCustomSecretForPatchContainerd option, enable it by default - #1104
Conversation
|
Warning Rate limit exceededAndrei Kvapil (@kvaps) has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 54 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (11)
WalkthroughThis change removes the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant HelmChart
participant KubernetesAPI
User->>HelmChart: Install/Upgrade chart
HelmChart->>KubernetesAPI: Lookup "patch-containerd" secret in "cozy-system"
alt Secret found
HelmChart->>KubernetesAPI: Create Secret in release namespace
else Secret not found
HelmChart->>KubernetesAPI: No action
end
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/apps/kubernetes/Chart.yaml (1)
19-19: Patch-level bump looks good; remember to record it in CHANGELOG
Incrementing from0.24.1to0.24.2correctly signals a backward-compatible change. Please double-check that a matching entry is added to the project’s CHANGELOG / release notes so downstream users understand the rationale.packages/apps/kubernetes/README.md (1)
84-89: Removed option is no longer documented—consider adding a note about the new default
TheuseCustomSecretForPatchContainerdrow has been dropped, but users upgrading from ≤ 0.24.1 may look for it. A short “Breaking-change / behaviour change” note in the README (or CHANGELOG) explaining that the copy-patch secret is now always enabled would help avoid confusion.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
packages/apps/kubernetes/Chart.yaml(1 hunks)packages/apps/kubernetes/README.md(1 hunks)packages/apps/kubernetes/templates/copy-patch-containerd.yaml(0 hunks)packages/apps/kubernetes/values.schema.json(0 hunks)packages/apps/kubernetes/values.yaml(0 hunks)packages/apps/versions_map(1 hunks)
💤 Files with no reviewable changes (3)
- packages/apps/kubernetes/values.yaml
- packages/apps/kubernetes/values.schema.json
- packages/apps/kubernetes/templates/copy-patch-containerd.yaml
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Build
🔇 Additional comments (2)
packages/apps/versions_map (2)
49-50: Confirm the pinned commit hash for 0.24.1 is correct
kubernetes 0.24.1now points to6358fd7a. Make sure this hash exists in the main branch history (and isn’t force-pushed away) so historical builds remain reproducible.
49-50: HEAD tracking for 0.24.2 is expected
No issues spotted—the entry aligns with the Chart patch bump.
bb9d333 to
a793779
Compare
Signed-off-by: Andrei Kvapil <[email protected]> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> - **New Features** - Pull request workflows now support release pull requests by fetching artifacts from draft releases and running all jobs without label-based exclusions. - Test matrices are now generated dynamically, improving flexibility in end-to-end application testing. - Added a new end-to-end test verifying tenant creation with isolated mode enabled. - **Refactor** - Workflow steps and job dependencies have been streamlined for improved efficiency and maintainability. - Workflow names and concurrency group names have been updated for clarity. - Environment preparation and artifact handling have been unified into consolidated jobs. - Release-related workflow simplified to a single finalize job. - Makefile targets for asset copying and test execution have been reorganized for better modularity. - **Tests** - End-to-end application and cluster test scripts have been removed. - Removed collective end-to-end test target; individual app test targets remain. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Andrei Kvapil <[email protected]>
a793779 to
5602e97
Compare
1 participant
Signed-off-by: Andrei Kvapil [email protected]
Summary by CodeRabbit
useCustomSecretForPatchContainerdparameter from user documentation and configuration files for improved clarity.