[postgres] add backup and restore - #1086

packages/apps/postgres/README.md (1)

71-80: Correct bootstrap parameter paths
The docs list resources and resourcesPreset, but the chart expects bootstrap.resources and bootstrap.resourcesPreset. Please update the table to show the full parameter paths.

packages/apps/postgres/templates/backup-secret.yaml (2)

1-10: Expand secret rendering and rename keys
This template now renders when either backup or bootstrap is enabled and renames the secret to {{ .Release.Name }}-s3-creds with AWS_ACCESS_KEY_ID/AWS_SECRET_ACCESS_KEY fields. Verify that all consumers (e.g., db.yaml) use the new secret name and that bootstrap workflows correctly pull credentials from .Values.backup.

---

1-1: Suppress YAMLlint false positive
Helm directives like {{- if ... }} trigger YAMLlint errors but are valid in templates. Consider configuring your linter to ignore template control statements.

packages/apps/postgres/README.md (1)

61-70: Fix typo in backup parameters
The description for backup.enabled reads “pereiodic” and should be “periodic.” Also clarify that the cron schedule uses a six-field expression (seconds included).

packages/apps/postgres/templates/backup.yaml (1)

1-1: Suppress YAMLlint false positive
The leading {{- if .Values.backup.enabled }} triggers a syntax warning in YAMLlint. You can ignore or disable linting for Helm template directives.

packages/apps/postgres/templates/db.yaml (3)

8-21: Use toYaml + nindent for DRY templating
You can replace the manual block with:

{{- if .Values.backup.enabled }}
{{- toYaml .Values.backup | nindent 2 }}
{{- end }}

This avoids duplication if new backup props are added.

---

22-22: Remove trailing whitespace
YAMLlint flagged trailing spaces on this blank line. Please remove them to clean up the template.

---

31-43: Consolidate duplicated S3 credentials block
The s3Credentials stanza is duplicated under backup.barmanObjectStore and externalClusters. You could factor it into a named template or use toYaml to inject a single definition.

packages/apps/postgres/values.schema.json (5)

68-72: Clarify cron format in schema
The default uses a 6-field expression ("0 2 * * * *"), but the description doesn’t mention seconds. Add a note to the description or apply a JSON Schema pattern to enforce the six-field cron format.

---

73-77: Validate retentionPolicy format
Currently any string is accepted. You may want to add a pattern (e.g. ^\d+[dhm]$) to catch invalid values early.

---

78-82: Enforce destinationPath URL pattern
Consider adding a pattern or "format": "uri" to ensure destinationPath is a valid URL (e.g. ^s3://.+).

---

83-87: Add URL validation for endpointURL
Use "format": "uri" in the schema or a pattern to validate the endpoint URL.

---

128-128: Note changed default for resourcesPreset
The default moved from nano to micro, which increases resource requests on upgrade. Ensure this bump is documented in the changelog.

packages/apps/postgres/values.yaml (2)

64-67: Align key order with doc comments
The schedule, retentionPolicy, destinationPath, and endpointURL properties are out of order relative to their @param doc headers. Reordering to match documentation improves readability.

---

101-101: Document upgrade impact of resourcesPreset default
Since you’ve bumped the default from "nano" to "micro", specify in the README or upgrade notes that resource usage will increase on chart upgrades.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

packages/apps/postgres/README.md (1)

20-37: Update restore instructions to match new backup mechanism
The “How to restore backup” section still references restic, but the new implementation uses CNPG’s bootstrap flow and ScheduledBackup resources. Please remove or update these instructions to reflect the new process.

packages/apps/postgres/templates/db.yaml (2)

8-21: Missing schedule field under cluster backup spec
The CNPG cluster backup block defines retention and object store settings but lacks the schedule property, which is required to schedule backups. Add:

 spec:
   {{- if .Values.backup.enabled }}
   backup:
+    schedule: {{ .Values.backup.schedule | quote }}
     barmanObjectStore:
       destinationPath: {{ .Values.backup.destinationPath }}
       endpointURL: {{ .Values.backup.endpointURL }}
     retentionPolicy: {{ .Values.backup.retentionPolicy }}
   {{- end }}

---

23-31: Enforce oldName validation when bootstrapping
If bootstrap.enabled is true, .Values.bootstrap.oldName must be non-empty to generate a valid recovery source. Use:

source: {{ required "bootstrap.oldName is required when bootstrap.enabled=true" .Values.bootstrap.oldName }}

packages/apps/postgres/values.schema.json (1)

100-119: Schema should require oldName when bootstrap is enabled
The bootstrap object lacks a required constraint for oldName (and possibly recoveryTime when needed). Consider adding a "required": ["oldName"] or using an if/then JSON Schema construct to enforce this.

packages/apps/postgres/values.yaml (1)

78-88: Enforce bootstrap.oldName when enabled
The bootstrap.oldName field must be set when bootstrap.enabled=true to avoid silent failures. Add a Helm required assertion in your templates (or document this dependency clearly).

packages/apps/postgres/README.md (1)

61-69: Typo in backup parameters table
Found “Enable pereiodic backups” – please correct the typo to “Enable periodic backups”.

packages/apps/postgres/values.schema.json (1)

63-71: Typo in JSON Schema description
The backup.enabled description reads “Enable pereiodic backups”. Please correct to “Enable periodic backups”.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro