Skip to content

[tests] Enhance timeouts awaitng for tenant Kubernetes cluster - #1004

Closed
Andrei Kvapil (kvaps) wants to merge 1 commit into
mainfrom
tests-kuber
Closed

[tests] Enhance timeouts awaitng for tenant Kubernetes cluster#1004
Andrei Kvapil (kvaps) wants to merge 1 commit into
mainfrom
tests-kuber

Conversation

@kvaps

@kvaps Andrei Kvapil (kvaps) commented May 29, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Signed-off-by: Andrei Kvapil [email protected]

Summary by CodeRabbit

  • Tests
    • Updated test case name to "Create a tenant Kubernetes cluster" for improved clarity.
    • Extended the timeout for waiting on the machinedeployment resource's readiness from 5 to 8 minutes to enhance test reliability.

@coderabbitai

coderabbitai Bot commented May 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The test case in the hack/e2e-apps.bats script was renamed to reflect a broader scope, and the timeout for waiting on the machinedeployment resource's readiness was increased from 5 to 8 minutes. No other changes were made to the test logic or resource definitions.

Changes

File(s) Change Summary
hack/e2e-apps.bats Renamed test case and increased machinedeployment timeout

Possibly related PRs

Suggested labels

backport

Suggested reviewers

  • lllamnyp
  • klinch0

Poem

A cluster awaits, with patience anew,
Timeout extended, just for the crew.
The test's name grows, its scope now vast,
Eight minutes to wait—no longer so fast!
Rabbits applaud with a hop and a cheer,
For clusters that form and tests that appear.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between beadc80 and 8bf2e67.

📒 Files selected for processing (1)
  • hack/e2e-apps.bats (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Build and Test
🔇 Additional comments (2)
hack/e2e-apps.bats (2)

26-26: LGTM: Improved test name for better clarity.

The test name change from "control plane" to "cluster" better reflects the actual scope of the test, which provisions both control plane and worker nodes (nodeGroups with machinedeployments).

93-93: LGTM: Timeout increase improves test reliability.

The timeout increase from 5m to 8m for readyReplicas is well-justified. Unlike the previous step that waits for replicas (just creation), this step waits for machines to be fully provisioned, join the cluster, and become operational - a process that naturally takes longer and can vary based on infrastructure conditions.

This change should reduce test flakiness while maintaining reasonable bounds for failure detection.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@lllamnyp

Timofei Larkin (lllamnyp) commented Jul 10, 2025

Copy link
Copy Markdown
Member

Stale, made obsolete by more recent improvements of tests

@IvanHunters IvanHunters mentioned this pull request Sep 17, 2026
Open
1 task done
Timur Tukaev (tym83) added a commit that referenced this pull request Sep 17, 2026
@tym83
docs(security): re-sync published pipeline copies to the hardened rev…
b180338 
…ision

Addresses @IvanHunters round-2 review of the published copies:
- re-sync report.py, monthly.py, backfill_issues.py, sync_issues.py and scan.sh to security-scanner#1004, and add the new statelib.py, so the HIGH-path guard, the shared crash-safe state I/O across all four readers, review_after enforcement, the persisted age-based auto-dismissal and the scan.sh env-export fix are all present in the copies an auditor reads — not just in one call site.
- README now names the exact source revision the copies correspond to (security-scanner#1004, commit b40462c1) and lists statelib.py. Once #1004 merges these match security-scanner main, the revision that runs on schedule.

Signed-off-by: Timur Tukaev <[email protected]>
Timur Tukaev (tym83) added a commit that referenced this pull request Sep 17, 2026
@tym83
docs(security): reference #1004 by number, not a commit that moves ea…
cfd96ce 
…ch round

Signed-off-by: Timur Tukaev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lllamnyp Timofei Larkin (lllamnyp) Awaiting requested review from lllamnyp lllamnyp is a code owner
@klinch0 klinch0 Awaiting requested review from klinch0

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

2 participants

@kvaps @lllamnyp