Skip to content

Typo in VPA system chart Makefile #705

Description

          _⚠️ Potential issue_

Naming inconsistency between package purpose and variables

There appears to be a mismatch between the directory name (vertical-pod-autoscaler) and the NAME variable (victoria-metrics-operator). This inconsistency could lead to confusion or errors in deployment.

-export NAME=victoria-metrics-operator
-export NAMESPACE=cozy-$(NAME)
+export NAME=vertical-pod-autoscaler
+export NAMESPACE=cozy-$(NAME)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

export NAME=vertical-pod-autoscaler
export NAMESPACE=cozy-$(NAME)

Originally posted by CodeRabbit (@coderabbitai)[bot] in #676 (comment)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions