tests: Remove LD_PREOAD from csplit-io-err.sh - #148
Conversation
|
I'm bit confused because test expects cc @ChrisDryden |
|
It seems this test is just avoiding |
| if ! test -w /dev/full || ! test -c /dev/full; then | ||
| skip_ '/dev/full is required' | ||
| fi | ||
| require_root_ |
There was a problem hiding this comment.
So a root constraint is better (less coupled) than LD_PRELOAD for uutils testing.
Fair enough
There was a problem hiding this comment.
I suppose strace might be an option too:
seq 10 | strace -o /dev/null -e inject='write:error=EIO:when=1..2' csplit - 1
There was a problem hiding this comment.
It seems uu-csplitcausing panic by strace...
There was a problem hiding this comment.
It seems
uu-csplitcausing panic bystrace...
Sounds like a bug in uu-csplit
There was a problem hiding this comment.
Hmm if this test requires root then that is a disadvantage.
Also this "error on write" case is handled by the symlink to /dev/full trick.
I.e. we should probably replace this test with the just created csplit-io-err-2.sh
There was a problem hiding this comment.
Message is bit different with csplit-io-err-2.sh. But if you think so, I'll just override.
Keeping old commit hash at 3827f37
|
In my thought, we needs 3 tests with different results and dependencies:
I don't know how many |
|
@ChrisDryden Would you |
| mkdir small || framework_failure_ | ||
| mount -t tmpfs -o size=1k tmpfs small || skip_ 'Unable to mount small tmpfs' | ||
|
|
||
| cleanup_() { umount small; rm -d small } |
There was a problem hiding this comment.
Missing a semicolon here after small
There was a problem hiding this comment.
Other than that the test works when running on my PR
|
Committed at 1b46778 |
3 participants
Experimental uutils/coreutils#9853