CL-5770: Cron correctness (POSIX steps, DOM/DOW OR, timezones) - #15
Closed
TheGreatAxios wants to merge 2 commits into
Conversation
Align packages/routines cron with Vixie/POSIX semantics and make schedules wall-clock safe. Step fields offset from field min; DOM/DOW OR when both restricted; day-of-week 7 is Sunday; optional IANA timezone on daily/weekly/cron with UTC storage; impossible expressions rejected at save via bounded lookahead. Web cadence/next-run shares the package path.
- Fix block-comment syntax error in cron.ts (*/N sequence closed the comment); reword to avoid the delimiter collision. - Apply prettier formatting to changed routine/hub files and a pre-existing prettier violation in webhook-triggers management-routes (required for prettier --check .). - Replace non-null assertions in routine-scheduler/store tests with an expectPresent narrowing helper.
TheGreatAxios
force-pushed
the
cl-5770-cron-correctness-step-fields-domdow-semantics-timezones
branch
from
August 9, 2026 07:00
27bcd95 to
2a2fac2
Compare
TheGreatAxios
deleted the branch
cl-5769-routines-hardening-ownership-checks-safe-claims-failure
August 9, 2026 07:09
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes CL-5770. Stacked on #13 (CL-5769) so routines package changes stay linear.
*/2on DOM → 1,3,5… not 2,4,6…)0 0 13 * 5= 13th or Friday)timezoneon daily / weekly / cron;nextFireAtremains a UTC instant; DST-correct viaIntl0 0 31 2 *) via bounded minute lookahead (366 days)@corbits/routines/cronpath and timezoneLogic stays in
packages/routines; web only renders.Test plan
bun test packages/routines/test/cron.test.ts packages/routines/test/trigger.test.tsbun test apps/web/test/routine-trigger.test.ts apps/hub/test/cron-due.test.tstsc --noEmitfor packages/routines, apps/web, apps/hub