dev: rebuild react-ui dist when git install left it empty - #10
Open
TheGreatAxios wants to merge 1 commit into
Open
dev: rebuild react-ui dist when git install left it empty#10TheGreatAxios wants to merge 1 commit into
TheGreatAxios wants to merge 1 commit into
Conversation
Local bun install sometimes leaves @corbits/react-ui without a prepare build, so vite fails on styles.css. Run the package prepare when dist/styles.css is missing, then continue the web build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Local
bun run devcan fail at the web build with Rollup unable to resolve@corbits/react-ui/styles.csswhen a git install of react-ui never produceddist/. CI stays green because clean installs usually run prepare; local trees sometimes do not.bun run devnow checks fordist/styles.cssand, if missing, runs the package's ownscripts/prepare.mjsbefore building the web app. Happy path (dist already present) is unchanged.Fixes CL-5767.
Test plan
dist/present:bun run devstill boots without an extra prepareapps/web/node_modules/@corbits/react-ui/dist:bun run devlogs the prepare step, rebuilds dist, then builds web successfully