Use Corbits Tag for Slack approval workflows - #15
Open
pratikbuilds wants to merge 15 commits into
Open
Conversation
TheGreatAxios
self-requested a review
July 31, 2026 16:53
pratikbuilds
changed the base branch from
main
to
agent/use-corbits-tag-for-interchange-agent
August 2, 2026 09:02
pvams
approved these changes
Aug 3, 2026
TheGreatAxios
approved these changes
Aug 3, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Contributor
There was a problem hiding this comment.
Code Approved - but please update Interchange -> Corbits text for the tag
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Contributor
There was a problem hiding this comment.
Self-review (agent)
Verdict: Approve
What this PR does
Moves the Slack approval workflow onto Corbits Tag + Chat SDK cards/actions. Deletes the unused shared Bolt bridge (src/slack/*, adapter, block kit helpers). Approvals resume or cancel the local Interchange run from button actions. Reuses the shared Tag workspace from #14 (no second gitlink).
Findings
| Severity | Finding |
|---|---|
| minor | Stale/forged/already-decided actions silently no-op — no ephemeral feedback. #22 later adds “This approval is no longer active.” for this sibling; worth either landing that here or accepting as stack follow-up. |
| minor | Decision correlation uses runId button value + thread map, but not message-id binding. Adequate for a starter; post-to-X’s correlation is stronger. |
| minor | No session unit tests on the rewrite (draft failure, stale action, double-click). |
| nit | cli.ts closes over chat before const chat = mounted.bot (safe if onTag is never sync — same sibling pattern). |
What looks solid
- Double-click:
decisionis set beforeawait signal/cancel; reset on error - Start-card post failure cancels the run and drops the active map entry
- Config drops Socket Mode
appToken; validates port + signing secret + bot token at startup - Incremental scope is cleanly
starter/slack-approval-flow/**against #14
Checks
- Full read of
session.ts,cards.ts,cli.ts,config.ts,workflow.ts git diff --name-statusbase…HEAD — bridge fully deleted- Live Slack approval flow not re-exercised in this review
No blockers. Squash-on-merge recommended for stack merge noise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mountSlackTagTesting
bun run --filter '*' typecheckDependency
Depends on #14. This branch is authored directly on top of its head commit.