Honor skip-permissions through pre-gate workspace sandboxes - #436
Merged
TheGreatAxios merged 1 commit intoAug 9, 2026
Merged
Conversation
Under --dangerously-skip-permissions the gate already auto-allows, but path-escape, delete_file, list_dir, and shell cwd retention still hard- denied outside-workspace paths. Thread getSkipPermissions into those sandboxes so yolo mode can reach other repos and retain out-of-tree shell cwd, while secret-guard and authz hard denies stay in force.
Collaborator
Author
Self-reviewWhat this fixes. Gate already short-circuits on Approach. Expose immutable Checks I care about.
Residual risk (accepted).
No code changes from this review. Ready to merge. |
TheGreatAxios
deleted the
cl-5807-agent-still-hits-permission-friction-under-dangerously-skip
branch
August 9, 2026 10:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Under
--dangerously-skip-permissionsthe permission gate already auto-allows every action that is not an authz hard deny, but several pre-gate workspace sandboxes still hard-denied outside-workspace paths. That left yolo mode agents stuck when reading another repo, deleting/listing outside the tree, or retaining a shell cwd that left the session root.This change threads
permissionGate.getSkipPermissions()into:pathEscapePlugin(allowOutside)deleteFilePlugin(allowOutside)createListDirTool/listDirectory(allowOutside)shellGuardPlugin/resolvePerCallShellCwd(allowOutsideCwd/allowOutsideSession)Secret-guard path denies and authorization hard blocks remain intentional and unchanged. Auto mode without skip still asks / denies on outside-workspace access.
Test plan
bun run typecheck && bun run build && bun run test(4346 pass)read_file,git cloneat the gate, path-escape allowOutside, list_dir / delete_file / shell cwd bounds with and without skipCloses https://linear.app/abklabs/issue/CL-5807/agent-still-hits-permission-friction-under-dangerously-skip-permissions