-
Notifications
You must be signed in to change notification settings - Fork 1
Expand file tree
/
Copy pathverify-plugin.test.ts
More file actions
318 lines (296 loc) · 11.2 KB
/
Copy pathverify-plugin.test.ts
File metadata and controls
318 lines (296 loc) · 11.2 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
import { describe, test, expect } from "bun:test";
import { mkdtemp, writeFile, rm, readFile } from "node:fs/promises";
import { join } from "node:path";
import { tmpdir } from "node:os";
import { verifyPlugin } from "./verify-plugin.js";
import type { ToolCall, ToolResult } from "@intx/types/runtime";
async function makeNextHandler(call: ToolCall): Promise<ToolResult> {
const path = String(call.arguments.path ?? "");
const content = String(call.arguments.content ?? "");
await writeFile(path, content);
return { callId: call.id, content: "written" };
}
describe("verifyPlugin", () => {
test("passes when write matches", async () => {
const dir = await mkdtemp(join(tmpdir(), "verify-test-"));
try {
const plugin = verifyPlugin();
const handler = plugin.middleware
? plugin.middleware(makeNextHandler)
: makeNextHandler;
const path = join(dir, "test.txt");
const result = await handler(
{
id: "call-1",
name: "write_file",
arguments: { path, content: "hello world" },
},
new AbortController().signal,
);
expect(result.isError).toBeUndefined();
} finally {
await rm(dir, { recursive: true, force: true });
}
});
test("fails when write is truncated", async () => {
const dir = await mkdtemp(join(tmpdir(), "verify-test-"));
try {
const plugin = verifyPlugin();
const badHandler = async (call: ToolCall): Promise<ToolResult> => {
const path = String(call.arguments.path ?? "");
await writeFile(path, "short");
return { callId: call.id, content: "written" };
};
const handler = plugin.middleware
? plugin.middleware(badHandler)
: badHandler;
const path = join(dir, "test.txt");
const result = await handler(
{
id: "call-1",
name: "write_file",
arguments: { path, content: "hello world" },
},
new AbortController().signal,
);
expect(result.isError).toBe(true);
expect(result.content).toMatch(/content mismatch/);
} finally {
await rm(dir, { recursive: true, force: true });
}
});
test("fails when write has same length but different content", async () => {
const dir = await mkdtemp(join(tmpdir(), "verify-test-"));
try {
const plugin = verifyPlugin();
const badHandler = async (call: ToolCall): Promise<ToolResult> => {
const path = String(call.arguments.path ?? "");
await writeFile(path, "XXXX XXXXXX"); // 11 chars, same length as "hello world"
return { callId: call.id, content: "written" };
};
const handler = plugin.middleware
? plugin.middleware(badHandler)
: badHandler;
const path = join(dir, "test.txt");
const result = await handler(
{
id: "call-1",
name: "write_file",
arguments: { path, content: "hello world" },
},
new AbortController().signal,
);
expect(result.isError).toBe(true);
expect(result.content).toMatch(/content mismatch/);
} finally {
await rm(dir, { recursive: true, force: true });
}
});
test("passes when edit_file matches expected result", async () => {
const dir = await mkdtemp(join(tmpdir(), "verify-test-"));
try {
const plugin = verifyPlugin();
const editHandler = async (call: ToolCall): Promise<ToolResult> => {
const path = String(call.arguments.path ?? "");
const oldStr = String(call.arguments.old_string ?? "");
const newStr = String(call.arguments.new_string ?? "");
const content = await readFile(path, "utf8");
const updated = content.replace(oldStr, newStr);
await writeFile(path, updated);
return { callId: call.id, content: "edited" };
};
const handler = plugin.middleware
? plugin.middleware(editHandler)
: editHandler;
const path = join(dir, "test.txt");
await writeFile(path, "hello world");
const result = await handler(
{
id: "call-1",
name: "edit_file",
arguments: { path, old_string: "world", new_string: "universe" },
},
new AbortController().signal,
);
expect(result.isError).not.toBe(true);
} finally {
await rm(dir, { recursive: true, force: true });
}
});
test("fails when edit_file produces wrong result", async () => {
const dir = await mkdtemp(join(tmpdir(), "verify-test-"));
try {
const plugin = verifyPlugin();
const badHandler = async (call: ToolCall): Promise<ToolResult> => {
const path = String(call.arguments.path ?? "");
await writeFile(path, "wrong content");
return { callId: call.id, content: "edited" };
};
const handler = plugin.middleware
? plugin.middleware(badHandler)
: badHandler;
const path = join(dir, "test.txt");
await writeFile(path, "hello world");
const result = await handler(
{
id: "call-1",
name: "edit_file",
arguments: { path, old_string: "world", new_string: "universe" },
},
new AbortController().signal,
);
expect(result.isError).toBe(true);
expect(result.content).toMatch(/content mismatch after replacement/);
} finally {
await rm(dir, { recursive: true, force: true });
}
});
test("skips verification when edit_file mixes substring and line-range args", async () => {
const dir = await mkdtemp(join(tmpdir(), "verify-test-"));
try {
const plugin = verifyPlugin();
// Mixed-mode is invalid at the parse layer; verify should not treat it as
// a successful line-range edit even if the underlying write applied one.
const editHandler = async (call: ToolCall): Promise<ToolResult> => {
const path = String(call.arguments.path ?? "");
const start = Number(call.arguments.start_line);
const end = Number(call.arguments.end_line);
const newStr = String(call.arguments.new_string ?? "");
const content = await readFile(path, "utf8");
const lines = content.split("\n");
const before = lines.slice(0, start - 1);
const after = lines.slice(end);
const inserted = newStr.split("\n");
const merged = [...before, ...inserted, ...after].join("\n");
await writeFile(path, merged.endsWith("\n") ? merged : merged + "\n");
return { callId: call.id, content: "edited" };
};
const handler = plugin.middleware ? plugin.middleware(editHandler) : editHandler;
const path = join(dir, "mixed.txt");
await writeFile(path, "a\nb\nc\n");
const result = await handler(
{
id: "call-mixed",
name: "edit_file",
arguments: {
path,
old_string: "b",
start_line: 2,
end_line: 2,
new_string: "B",
},
},
new AbortController().signal,
);
// Invalid mode short-circuits verification; result is whatever the handler returned.
expect(result.isError).not.toBe(true);
expect(result.content).toBe("edited");
} finally {
await rm(dir, { recursive: true, force: true });
}
});
test("passes when edit_file line-range mode matches expected result", async () => {
const dir = await mkdtemp(join(tmpdir(), "verify-test-"));
try {
const plugin = verifyPlugin();
const editHandler = async (call: ToolCall): Promise<ToolResult> => {
const path = String(call.arguments.path ?? "");
const start = Number(call.arguments.start_line);
const end = Number(call.arguments.end_line);
const newStr = String(call.arguments.new_string ?? "");
const content = await readFile(path, "utf8");
const lines = content.split("\n");
const before = lines.slice(0, start - 1);
const after = lines.slice(end);
const inserted = newStr.split("\n");
const merged = [...before, ...inserted, ...after].join("\n");
await writeFile(path, merged.endsWith("\n") ? merged : merged + "\n");
return { callId: call.id, content: "edited" };
};
const handler = plugin.middleware ? plugin.middleware(editHandler) : editHandler;
const path = join(dir, "range.txt");
await writeFile(path, "a\nb\nc\n");
const result = await handler(
{
id: "call-range",
name: "edit_file",
arguments: { path, start_line: 2, end_line: 2, new_string: "B" },
},
new AbortController().signal,
);
expect(result.isError).not.toBe(true);
} finally {
await rm(dir, { recursive: true, force: true });
}
});
test("fails when edit_file line-range produces wrong result", async () => {
const dir = await mkdtemp(join(tmpdir(), "verify-test-"));
try {
const plugin = verifyPlugin();
const badHandler = async (call: ToolCall): Promise<ToolResult> => {
const path = String(call.arguments.path ?? "");
await writeFile(path, "wrong\n");
return { callId: call.id, content: "edited" };
};
const handler = plugin.middleware ? plugin.middleware(badHandler) : badHandler;
const path = join(dir, "range-bad.txt");
await writeFile(path, "a\nb\n");
const result = await handler(
{
id: "call-range-bad",
name: "edit_file",
arguments: { path, start_line: 2, end_line: 2, new_string: "B" },
},
new AbortController().signal,
);
expect(result.isError).toBe(true);
expect(result.content).toMatch(/content mismatch after replacement/);
} finally {
await rm(dir, { recursive: true, force: true });
}
});
test("serializes parallel edit_file on the same path", async () => {
const dir = await mkdtemp(join(tmpdir(), "verify-test-"));
try {
const plugin = verifyPlugin();
const editHandler = async (call: ToolCall): Promise<ToolResult> => {
const path = String(call.arguments.path ?? "");
const oldStr = String(call.arguments.old_string ?? "");
const newStr = String(call.arguments.new_string ?? "");
const content = await readFile(path, "utf8");
const updated = content.replace(oldStr, newStr);
await writeFile(path, updated);
return { callId: call.id, content: "edited" };
};
const handler = plugin.middleware
? plugin.middleware(editHandler)
: editHandler;
const path = join(dir, "test.txt");
await writeFile(path, "aaa bbb ccc");
const [r1, r2] = await Promise.all([
handler(
{
id: "call-1",
name: "edit_file",
arguments: { path, old_string: "aaa", new_string: "AAA" },
},
new AbortController().signal,
),
handler(
{
id: "call-2",
name: "edit_file",
arguments: { path, old_string: "bbb", new_string: "BBB" },
},
new AbortController().signal,
),
]);
expect(r1.isError).not.toBe(true);
expect(r2.isError).not.toBe(true);
const final = await readFile(path, "utf8");
expect(final).toBe("AAA BBB ccc");
} finally {
await rm(dir, { recursive: true, force: true });
}
});
});