Repository navigation
Refactor: Move the IO-free parts of the HTTP client into shared modules - #840
Open
bgunebakan wants to merge 8 commits into
Open
bgunebakan wants to merge 8 commits into
bgunebakan wants to merge 8 commits into
Conversation
bgunebakan
changed the title
http.py into private modules![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
florinutz
approved these changes
Oct 15, 2026
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes / Why this is an improvement
Moves the IO-free parts of
http.pyinto private modules, so that a planned async client can share them instead of duplicating them.This is a pure move with no behavior change, and no changelog entry because nothing changes for users.
This is part of Async implementation. https://github.com/crate/ecosystem/issues/54
Some old names are no longer importable from
crate.client.http._create_sql_payload,_server_url,_to_server_list,patand_HTTP_PATwere dropped because nothing uses them.Note to reviewer
This PR is constructed with first 6 commits and each of them for moving different part of the http.py, would be easy to review each commit separately.
Checklist