Skip to content
This repository was archived by the owner on Sep 2, 2026. It is now read-only.

Restrict EPG delete with active EPs - #484

Merged
shaleman merged 1 commit into
contiv:masterfrom
dvavili:epDelete
Aug 17, 2016
Merged

shaleman merged 1 commit into
contiv:masterfrom
dvavili:epDelete

Conversation

@dvavili

@dvavili dvavili commented Aug 1, 2016

Copy link
Copy Markdown
Contributor

PR includes:

  • State change in EPG to maintain active EP count and restrict deletion when active EPs are present
  • Fix bug in network deletion on active EPs (the operation was partially cleaning up tenant state)
  • Fix some minor typo

@gaurav-dalvi

Copy link
Copy Markdown
Contributor

LGTM

Comment thread netmaster/master/endpointGroup.go Outdated
}

if epgCfg.EpCount != 0 {
return core.Errorf("Error: EPG has active endpoints")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we mention the epg name here ? So while debugging we can use epg inspect to list the active endpoints.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a EPG name here

@dvavili
dvavili force-pushed the epDelete branch 4 times, most recently from 06dade0 to bd70409 Compare August 15, 2016 18:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants