Skip to content

Fix/workflow and ct gf overwrite fix#78

Merged
nadeem-cs merged 4 commits intonextfrom
fix/workflow-and-CT-GF-overwrite-fix
Aug 22, 2023
Merged

Fix/workflow and ct gf overwrite fix#78
nadeem-cs merged 4 commits intonextfrom
fix/workflow-and-CT-GF-overwrite-fix

Conversation

@nadeem-cs
Copy link
Copy Markdown
Contributor

@nadeem-cs nadeem-cs commented Aug 22, 2023

No description provided.

@nadeem-cs nadeem-cs requested a review from a team as a code owner August 22, 2023 10:32
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 22, 2023 •
edited
Loading

Coverage report for commit: 8e7ae31
File: coverage/clover.xml

Cover ┌─────────────────────────┐ Freq.
   0% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  10% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  20% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  30% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  40% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  50% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  60% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  70% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  80% │ ██████████░░░░░░░░░░░░░ │ 18.4%
  90% │ ███████████████████░░░░ │ 36.8%
 100% │ ███████████████████████ │ 44.7%
      └─────────────────────────┘
 *Legend:* █ = Current Distribution
Summary - Lines: 90.26% | Methods: 97.57% | Branches: 74.05%
FilesLinesMethodsBranches
lib/app/authorization
   index.js91.67%100.00%72.09%
lib/app/hosting
   deployment.js85.29%100.00%65.79%
   index.js80.70%100.00%59.09%
lib/app
   index.js92.78%100.00%66.12%
lib/app/installation
   index.js84.62%100.00%59.55%
lib/app/request
   index.js91.43%100.00%65.85%
lib
   contentstack.js100.00%100.00%100.00%
   contentstackClient.js100.00%100.00%85.00%
   contentstackCollection.js100.00%100.00%100.00%
   entity.js85.62%100.00%62.12%
lib/core
   Util.js96.36%100.00%83.64%
   concurrency-queue.js91.86%93.75%86.32%
   contentstackError.js100.00%100.00%100.00%
   contentstackHTTPClient.js98.00%100.00%93.48%
lib/organization
   index.js83.33%100.00%60.98%
lib/query
   index.js80.43%100.00%67.27%
lib/stack/asset/folders
   index.js100.00%100.00%100.00%
lib/stack/asset
   index.js84.85%84.21%64.00%
lib/stack/auditlog
   index.js95.83%100.00%75.76%
lib/stack/branch
   compare.js81.82%100.00%71.88%
   index.js97.44%100.00%80.56%
   mergeQueue.js100.00%100.00%73.68%
lib/stack/branchAlias
   index.js86.21%100.00%65.85%
lib/stack/contentType/entry
   index.js91.04%100.00%73.77%
lib/stack/contentType
   index.js83.02%85.71%70.18%
lib/stack/deliveryToken
   index.js100.00%100.00%94.44%
lib/stack/environment
   index.js100.00%100.00%100.00%
lib/stack/extension
   index.js95.92%100.00%87.76%
lib/stack/globalField
   index.js94.12%100.00%83.78%
lib/stack
   index.js86.21%89.47%75.45%
lib/stack/label
   index.js100.00%100.00%100.00%
lib/stack/locale
   index.js100.00%100.00%100.00%
lib/stack/release
   index.js91.11%100.00%72.34%
lib/stack/roles
   index.js100.00%100.00%100.00%
lib/stack/webhook
   index.js89.66%100.00%72.88%
lib/stack/workflow
   index.js89.09%100.00%72.31%
lib/stack/workflow/publishRules
   index.js100.00%100.00%100.00%
lib/user
   index.js94.29%100.00%82.14%

🤖 comment via lucassabreu/comment-coverage-clover

ishaileshmishra
ishaileshmishra reviewed Aug 22, 2023
View reviewed changes
Comment thread lib/stack/contentType/index.js
ishaileshmishra
ishaileshmishra reviewed Aug 22, 2023
View reviewed changes
Comment thread lib/stack/globalField/index.js
ishaileshmishra
ishaileshmishra suggested changes Aug 22, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@ishaileshmishra ishaileshmishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few comments, please check @nadeem-cs

@nadeem-cs
Copy link
Copy Markdown
Contributor Author

nadeem-cs commented Aug 22, 2023

Resolved the conversations. Pls check and provide approval @ishaileshmishra

ishaileshmishra
ishaileshmishra approved these changes Aug 22, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@ishaileshmishra ishaileshmishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@nadeem-cs nadeem-cs merged commit 9ee8f50 into next Aug 22, 2023
@nadeem-cs nadeem-cs deleted the fix/workflow-and-CT-GF-overwrite-fix branch September 27, 2023 20:00
@nadeem-cs nadeem-cs added the Next label Sep 28, 2023
sunil-lakshman pushed a commit that referenced this pull request Jun 26, 2024
@nadeem-cs
Merge pull request #78 from contentstack/fix/workflow-and-CT-GF-overw…
81c5cea 
…rite-fix

Fix/workflow and ct gf overwrite fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ishaileshmishra ishaileshmishra ishaileshmishra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nadeem-cs @ishaileshmishra