Skip to content

fix: added fix for missing fs error#144

Merged
abhinav-from-contentstack merged 3 commits intonextfrom
fix/dx-174
May 9, 2024
Merged

fix: added fix for missing fs error#144
abhinav-from-contentstack merged 3 commits intonextfrom
fix/dx-174

Conversation

@abhinav-from-contentstack
Copy link
Copy Markdown
Contributor

@abhinav-from-contentstack abhinav-from-contentstack commented May 8, 2024

  • added fix for missing fs issue in web build
  • updated version to 1.16.1

@abhinav-from-contentstack abhinav-from-contentstack requested a review from a team as a code owner May 8, 2024 09:26
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2024 •
edited
Loading

Coverage report for commit: 5a5c4a0
File: coverage/clover.xml

Cover ┌─────────────────────────┐ Freq.
   0% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  10% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  20% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  30% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  40% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  50% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  60% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  70% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  80% │ █████████░░░░░░░░░░░░░░ │ 15.9%
  90% │ ██████████████████████░ │ 40.9%
 100% │ ███████████████████████ │ 43.2%
      └─────────────────────────┘
 *Legend:* █ = Current Distribution
Summary - Lines: 90.11% | Methods: 97.85% | Branches: 72.90%
FilesLinesMethodsBranches
lib/app/authorization
   index.js91.67%100.00%72.09%
lib/app/hosting
   deployment.js85.29%100.00%65.79%
   index.js80.70%100.00%59.09%
lib/app
   index.js92.78%100.00%66.12%
lib/app/installation
   index.js84.62%100.00%59.55%
lib/app/request
   index.js91.43%100.00%65.85%
lib
   contentstack.js100.00%100.00%100.00%
   contentstackClient.js100.00%100.00%85.00%
   contentstackCollection.js100.00%100.00%100.00%
   entity.js85.00%100.00%62.89%
lib/core
   Util.js96.36%100.00%83.64%
   concurrency-queue.js94.19%100.00%85.12%
   contentstackError.js100.00%100.00%100.00%
   contentstackHTTPClient.js98.08%100.00%93.75%
lib/organization
   index.js83.33%100.00%60.67%
lib/organization/teams
   index.js92.11%100.00%68.42%
lib/organization/teams/stackRoleMappings
   index.js89.29%100.00%58.14%
lib/organization/teams/teamUsers
   index.js100.00%100.00%93.75%
lib/query
   index.js80.43%100.00%67.27%
lib/stack/asset/folders
   index.js100.00%100.00%100.00%
lib/stack/asset
   index.js85.29%84.21%64.94%
lib/stack/auditlog
   index.js95.83%100.00%75.76%
lib/stack/branch
   compare.js81.82%100.00%71.88%
   index.js97.44%100.00%80.56%
   mergeQueue.js100.00%100.00%73.68%
lib/stack/branchAlias
   index.js86.21%100.00%65.85%
lib/stack/contentType/entry
   index.js89.61%100.00%69.44%
lib/stack/contentType
   index.js83.02%85.71%70.18%
lib/stack/deliveryToken
   index.js100.00%100.00%94.44%
lib/stack/environment
   index.js100.00%100.00%100.00%
lib/stack/extension
   index.js95.92%100.00%87.76%
lib/stack/globalField
   index.js94.12%100.00%83.78%
lib/stack
   index.js82.89%85.00%71.13%
lib/stack/label
   index.js100.00%100.00%100.00%
lib/stack/locale
   index.js100.00%100.00%100.00%
lib/stack/managementToken
   index.js100.00%100.00%94.44%
lib/stack/release
   index.js91.11%100.00%72.34%
lib/stack/roles
   index.js100.00%100.00%100.00%
lib/stack/taxonomy
   index.js88.00%100.00%64.52%
lib/stack/taxonomy/terms
   index.js92.31%100.00%72.55%
lib/stack/webhook
   index.js89.66%100.00%72.88%
lib/stack/workflow
   index.js89.09%100.00%72.31%
lib/stack/workflow/publishRules
   index.js100.00%100.00%100.00%
lib/user
   index.js94.29%100.00%82.14%

🤖 comment via lucassabreu/comment-coverage-clover

sunil-lakshman
sunil-lakshman reviewed May 8, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@sunil-lakshman sunil-lakshman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhinav-from-contentstack Please update the changelog file.

reeshika-h
reeshika-h approved these changes May 8, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@reeshika-h reeshika-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@abhinav-from-contentstack
Copy link
Copy Markdown
Contributor Author

abhinav-from-contentstack commented May 8, 2024

done @sunil-lakshman

sunil-lakshman
sunil-lakshman approved these changes May 8, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@sunil-lakshman sunil-lakshman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

nadeem-cs
nadeem-cs approved these changes May 8, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@nadeem-cs nadeem-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

sunil-lakshman pushed a commit that referenced this pull request Jun 26, 2024
@abhinav-from-contentstack
Merge pull request #144 from contentstack/fix/dx-174
ae0dd5c 
fix: added fix for missing fs error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunil-lakshman sunil-lakshman sunil-lakshman approved these changes

@reeshika-h reeshika-h reeshika-h approved these changes

+1 more reviewer

@nadeem-cs nadeem-cs nadeem-cs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@abhinav-from-contentstack @sunil-lakshman @nadeem-cs @reeshika-h