Skip to content

Use pickle instead of repr/ast.literal_eval#34

Open
rotu wants to merge 2 commits into
colcon:masterfrom
rotu:pickle
Open

Use pickle instead of repr/ast.literal_eval#34
rotu wants to merge 2 commits into
colcon:masterfrom
rotu:pickle

Conversation

@rotu
Copy link
Copy Markdown
Contributor

@rotu rotu commented Apr 22, 2020

This fixes a crash with objects likeSpecifierSet, e.g. when python version compatibility is specified in setup.py

@rotu rotu force-pushed the pickle branch 3 times, most recently from 3a15f37 to 7cbccfe Compare April 22, 2020 23:15
This fixes a crash with objects like`SpecifierSet`
@rotu
Copy link
Copy Markdown
Contributor Author

rotu commented Apr 30, 2020

This is ready. To test, you can try building tox with colcon. It crashes colcon before this PR.

@anand-bala
Copy link
Copy Markdown

Any updates with this? I am using the python_requires field, and get a SyntaxError. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants