Add Enhancement(promptService): add prompt if user has unsaved change…#163
Conversation
…s and tries to naivgate from create page
xiaoniuniu89
requested review from
NiallJoeMaher and
pkspyder007
as code owners
|
@xiaoniuniu89 is attempting to deploy a commit to the Codú Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Build is failing. 😢
It might take a day or two for me to review this while I'm travelling so sorry in advance for the delay! |
|
im sorry, looks like a typo in the import statement, I have no idea how I changed that when pushing changes, will update later today! |
fix typo
NiallJoeMaher
left a comment
NiallJoeMaher
left a comment
There was a problem hiding this comment.
Looks great! That will come in useful in a lot of other places too.
One small thing this is probably unwanted behaviour:
Screen.Recording.2023-02-22.at.21.24.39.mov
If a user comes back, the page saves (which will publish updates) which might not be intended.
So I guess the user updating the article should only be by manually pressing the save button.
Thanks for this btw!
Runs really nicely. 🦾
|
Also, sorry about the major delay! I was away for a couple of weeks and hoped someone else would have the chance to look. 😢 |
|
No worries, will look at this at the weekend!! |
xiaoniuniu89
requested review from
NiallJoeMaher
and removed request for
pkspyder007
NiallJoeMaher
left a comment
NiallJoeMaher
left a comment
There was a problem hiding this comment.
LGTM! Thank you ❤️
xiaoniuniu89
deleted the
dancallaghan/user_prompt_unsaved_changes_issue117
branch
#163) * Add Enhancement(promptService): add prompt if the user has unsaved changes and tries to navigate from create page * Update [[...postIdArr]].tsx * add a check if the article was published before saving after cancel route change
2 participants
…s and tries to naivgate from create page
✨ Codu Pull Request 💻
👉 Please remove the below and replace with your own values, leaving the headers where they are. 👈
Pull Request details:
Any Breaking changes:
None
Associated Screenshots:
( Welcome file extensions include gifs/png screenshots of your feature in action )
None