Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: codu-code/codu
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 80bbc3d
Choose a base ref
...
head repository: codu-code/codu
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e8922ee
Choose a head ref
  • 1 commit
  • 3 files changed
  • 2 contributors

Commits on Jun 17, 2026

  1. fix(s3): trim whitespace in bucket name + creds so uploads can't brea… 

    …k on a stray space (#1338)

* fix(s3): trim whitespace in bucket name + creds so uploads can't break on a stray space

A trailing space in the prod S3_BUCKET_NAME env var made every presigned PUT
target the invalid bucket "codu.uploads " -> S3 returned 400 InvalidBucketName,
taking uploads down entirely. The whitespace is invisible in the Vercel UI, and
S3_BUCKET_NAME/ACCESS_KEY/SECRET_KEY aren't in config/env.js validation, so the
bad value failed silently at runtime instead of at boot.

Trim these values at the point of use (getPresignedUrl bucket name, s3 client
credentials) so stray whitespace on any of them can't break signing or the PUT.
Adds a regression test that fails without the trim (URL came out as
.../codu.uploads%20/...) and passes with it.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

* chore(review): self-contained test cleanup + drop stale @fix comment

- restore process.env in afterAll so the suite doesn't lean on neighbours
- remove the misleading `// @fix TS ERROR` comment (no actual error)

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <[email protected]>
    @NiallJoeMaher @claude
    NiallJoeMaher and claude authored Jun 17, 2026
    Configuration menu
    Copy the full SHA
    e8922ee View commit details
    Browse the repository at this point in the history
Loading