Skip to content

Allow the proxies in requests download - #46

Merged
zsimic merged 1 commit into
codrsquad:mainfrom
grammy-jiang:feature/MAST-9416-allow-proxy-in-downloading
Apr 9, 2024
Merged

zsimic merged 1 commit into
codrsquad:mainfrom
grammy-jiang:feature/MAST-9416-allow-proxy-in-downloading

Conversation

@grammy-jiang

@grammy-jiang grammy-jiang commented Apr 8, 2024 •

Copy link
Copy Markdown
Contributor

This pull request enables to download with the environment variables of HTTP_PROXY, HTTPS_PROXY, http_proxy and https_proxy.

Refer to:

@grammy-jiang

Copy link
Copy Markdown
Contributor Author

This pull request is quite similar with #44 - introduce the environment variables to the compiling process. In the future these environment variables introduce will be probably moved to a configurable feature.

@zsimic zsimic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with using proxies, but this LGTM

@zsimic
zsimic merged commit d01d8ce into codrsquad:main Apr 9, 2024
@grammy-jiang
grammy-jiang deleted the feature/MAST-9416-allow-proxy-in-downloading branch April 9, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants