Repository navigation
Introduce PATH, LD_LIBRARY_PATH and PKG_CONFIG_PATH from running environment - #44
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
=======================================
Coverage 99.80% 99.80%
=======================================
Files 12 12
Lines 2051 2055 +4
=======================================
+ Hits 2047 2051 +4
Misses 4 4 ☔ View full report in Codecov by Sentry. |
Contributor
|
Thank you! I may change this to be opt-in in the future, behind a configuration setting, if/when it turns out to be an issue. |
grammy-jiang
deleted the
feature/MAST-9414-update-path-and-add-ld_library_path-and-pkg_config_path
branch
April 7, 2024 11:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduce the environment variables (PATH, LD_LIBRARY_PATH and PKG_CONFIG_PATH) from
portable-pythonexecuting environment.This will allow to use gcc/g++, and also custom library path when compiling the portable python.