Add speedtest command - #864
Merged
Merged
Conversation
EhabY
self-requested a review
March 29, 2026 11:27
EhabY
requested changes
Mar 29, 2026
Contributor
Author
|
@EhabY happy to contribute 😉 (should pass now 🙏) |
EhabY
reviewed
Apr 2, 2026
EhabY
left a comment
EhabY
left a comment
Collaborator
There was a problem hiding this comment.
Love the tests! I think we'll have to await Asher's response for the UX but the rest are smaller issues!
yazan-abu-obaideh
force-pushed
the
feat-750
branch
from
April 5, 2026 11:00
ac27aec to
bcd86f7
Compare
yazan-abu-obaideh
force-pushed
the
feat-750
branch
from
April 5, 2026 11:01
bcd86f7 to
b81afc6
Compare
EhabY
marked this pull request as ready for review
April 5, 2026 19:13
EhabY
reviewed
Apr 5, 2026
| binPath: string, | ||
| globalFlags: string[], | ||
| workspaceName: string, | ||
| options: { signal?: AbortSignal; duration?: string }, |
Collaborator
There was a problem hiding this comment.
I don't love mixing two different kinds of options, one for args and one for the execution itself 🤔
Actually maybe inline this, it's very similar to the one in commands#openAppStatus. If we want to separate it out for testability then maybe we use a separate file for this? Something like core/cliExec.ts? (we'd move the version to it)
EhabY
approved these changes
Apr 7, 2026
EhabY
left a comment
EhabY
left a comment
Collaborator
There was a problem hiding this comment.
Looks great now! Thanks for the contribution, much appreciated!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #750