Conversation
Docs previewCheck off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here. |
jakehwll
changed the title
status filter to be actual agent statuses
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 931356d089
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| archived: archivedFilter, | ||
| prStatuses: sidebarFilters.prStatuses, | ||
| chatStatus: chatStatusFilter, | ||
| statuses, |
There was a problem hiding this comment.
When a subset such as Error or Requires action is selected, this creates a status-filtered list cache, but a root created watch event still calls prependToInfiniteChatsCache, which only checks the archived filter. A newly created waiting or running chat is therefore inserted into the active nonmatching list, and the created branch does not invalidate the list, so the incorrect row can remain until a later status event or refetch. Make the prepend path status-aware or invalidate filtered lists for created events.
Useful? React with 👍 / 👎.
This branch has not been deployed
1 participant
The sidebar's
Chat statusfilter only offeredRead/Unread. This turns it into a real status filter backed by thechat_statusenum, the same value the row icon already shows. Stacked on #30006.status:<waiting|running|error|requires_action|interrupting>search filter (repeated or comma-separated) plus achat_statusesparam onGetChats.Statussubmenu offersRequires action,Error,WorkingandIdle;Workingcoversinterrupting, since stopping a turn is too brief to be worth its own option. A full selection emits no filter.Unreadmoves out to its own checkbox (unread=truein the URL), so it narrows a status selection instead of competing with it.Unread/Read, reusinggetChatStatusDisplayfor labels and icons.