Conversation
preview now evaluates only the parameter, preset, and tag closure by default. CODER_DYNAMIC_PARAMETERS_FULL_EVALUATION restores evaluating every resource, so a misbehaving template can be worked around without a release. Threaded through dynamicparameters.PreviewOptions to the template version tags, dynamic parameters websocket, and workspace builder render paths.
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Emyrk
changed the title
Contributor
Docs previewCheck off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a hidden deployment flag that turns off preview's resource closure optimization, so a template that renders incorrectly with it can be worked around without a coder release.
CODER_DYNAMIC_PARAMETERS_FULL_EVALUATION/--dynamic-parameters-full-evaluation(hidden, defaultfalse) onDeploymentValues.dynamicparameters.PreviewOptions(dv)maps it topreview.OptionFullEvaluation();dynamicparameters.WithPreviewOptionsthreads it through the loader topreview.Preview.wsbuilderbuilds created fromcoderd(which call.DeploymentValues(...)).Not covered: the autobuild lifecycle executor and the enterprise prebuilds reconciler construct
wsbuilderwithout deployment values, so builds started from those paths use preview's default regardless of the flag. Those only re-render for builds, not the keystroke websocket path the optimization targets.Prepared with Coder Agents assistance.